<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18607">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts_unknown: fix: properly initialize the feature vector<br><br>This is unlikely to cause any problems, but having a NULL-pointer<br>that can potentially be dereferenced is dangerous. Fix this.<br><br>Change-Id: Icf594604f69023d1483e897edb811e51774b5b8e<br>---<br>M src/osmo-bsc/bts_unknown.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/18607/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_unknown.c b/src/osmo-bsc/bts_unknown.c</span><br><span>index 5ecf875..b6b56a8 100644</span><br><span>--- a/src/osmo-bsc/bts_unknown.c</span><br><span>+++ b/src/osmo-bsc/bts_unknown.c</span><br><span>@@ -36,5 +36,11 @@</span><br><span> </span><br><span> int bts_model_unknown_init(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     /* NOTE: the buffer is zero-initialized by compiler */</span><br><span style="color: hsl(120, 100%, 40%);">+        model_unknown.features = (struct bitvec) {</span><br><span style="color: hsl(120, 100%, 40%);">+            .data_len = sizeof(model_unknown._features_data),</span><br><span style="color: hsl(120, 100%, 40%);">+             .data = &model_unknown._features_data[0],</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         return gsm_bts_model_register(&model_unknown);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18607">change 18607</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18607"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icf594604f69023d1483e897edb811e51774b5b8e </div>
<div style="display:none"> Gerrit-Change-Number: 18607 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>