<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/cards.py">File pySim/cards.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/cards.py@228">Patch Set #2, Line 228:</a> <code style="font-family:monospace,monospace">(EF['DIR'])</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> I think 214 was probably a bug anyway, as the record is in the MF, so just doing ['2f00'] will req […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">ok, I reverted the first one, ane left the old value. Happy to submit the other once this get merged, don't just in case there is a conflict</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/ts_31_102.py">File pySim/ts_31_102.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/ts_31_102.py@140">Patch Set #2, Line 140:</a> <code style="font-family:monospace,monospace">EF_ADF_map = {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">that's true.. but when you import in say pySim-read.py or cards. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/18564">change 18564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/18564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I458380bf46b2986662ecdede2551c22cd9be92ba </div>
<div style="display:none"> Gerrit-Change-Number: 18564 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-CC: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 May 2020 14:09:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>