<p>fixeria <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18565">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm: fix ARFCN list encoding in Set Channel Attributes<br><br>3GPP TS 12.21 defines coding of 'ARFCN List' attribute as follows:<br><br>  +---------------------------+--------------------+<br>  | Attribute Identifier      | 1st octet          |<br>  +---------------------------+--------------------+<br>  | Length                    | 2-3 octets         |<br>  +---------------------------+--------------------+<br>  | ARFCN1                    | 4-5 octets         |<br>  +---------------------------+--------------------+<br>  | ...                       | ...                |<br>  +---------------------------+--------------------+<br>  | ARFCNn                    | (n * 2 - 3) octets |<br>  +---------------------------+--------------------+<br><br>so this is basically TL16V, where L16 is the length of V.<br><br>In the Siemens dialect of OML coding rules are different though:<br><br>  +---------------------------+--------------------+<br>  | Attribute Identifier      | 1st octet          |<br>  +---------------------------+--------------------+<br>  | ARFCN count               | 2nd octet          |<br>  +---------------------------+--------------------+<br>  | ARFCN1                    | 4-5 octets         |<br>  +---------------------------+--------------------+<br>  | ...                       | ...                |<br>  +---------------------------+--------------------+<br>  | ARFCNn                    | (n * 2 - 2) octets |<br>  +---------------------------+--------------------+<br><br>so this is TCV, where C is the amount of ARFCNs in V.<br><br>This change fixes encoding of 'ARFCN List' for other dialects,<br>in particular encoding of the 'Length' field (1 vs 2 octets).<br>I verified the results in Wireshark (generic 3GPP TS 12.21<br>and ip.access dialect), everything looks good.<br><br>Change-Id: Iec1826f55459ac8e9355328a1a6bb0949874db60<br>Related: OS#4545<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 28 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/18565/2</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18565">change 18565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iec1826f55459ac8e9355328a1a6bb0949874db60 </div>
<div style="display:none"> Gerrit-Change-Number: 18565 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>