<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18598">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm: fix: properly warn about unknown BTS features<br><br>Change-Id: I40925ecc02ff94e510c04b048fe1bbc2066a7776<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 11 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/18598/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index db2879f..4e01b47 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -567,6 +567,7 @@</span><br><span> </span><br><span>    /* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.30 Manufacturer Id */</span><br><span>      if (TLVP_PRES_LEN(tp, NM_ATT_MANUF_ID, 2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          data = TLVP_VAL(tp, NM_ATT_MANUF_ID);</span><br><span>                len = TLVP_LEN(tp, NM_ATT_MANUF_ID);</span><br><span> </span><br><span>             /* log potential BTS feature vector overflow */</span><br><span>@@ -576,15 +577,17 @@</span><br><span>                      len = sizeof(bts->_features_data);</span><br><span>                }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* check that max. expected BTS attribute is above given feature vector length */</span><br><span style="color: hsl(0, 100%, 40%);">-               if (len > OSMO_BYTES_FOR_BITS(_NUM_BTS_FEAT)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      LOGP(DNM, LOGL_NOTICE, "BTS%u Get Attributes Response: reported unexpectedly long (%u bytes) "</span><br><span style="color: hsl(0, 100%, 40%);">-                             "feature vector - most likely it was compiled against newer BSC headers. "</span><br><span style="color: hsl(0, 100%, 40%);">-                            "Consider upgrading your BSC to later version.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                            bts->nr, len);</span><br><span style="color: hsl(0, 100%, 40%);">-          }</span><br><span style="color: hsl(120, 100%, 40%);">+             memcpy(bts->_features_data, data, len);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          memcpy(bts->_features_data, TLVP_VAL(tp, NM_ATT_MANUF_ID), len);</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Warn about new features that we're now aware of */</span><br><span style="color: hsl(120, 100%, 40%);">+             for (i = _NUM_BTS_FEAT; i < len * 8; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        rc = bitvec_get_bit_pos(&bts->features, i);</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (!rc)</span><br><span style="color: hsl(120, 100%, 40%);">+                              continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGP(DNM, LOGL_NOTICE, "BTS%u Get Attributes Response: unknown feature #%d. "</span><br><span style="color: hsl(120, 100%, 40%);">+                            "Consider upgrading your BSC/BTS to later version.\n", bts->nr, i);</span><br><span style="color: hsl(120, 100%, 40%);">+         }</span><br><span> </span><br><span>                for (i = 0; i < _NUM_BTS_FEAT; i++) {</span><br><span>                     if (osmo_bts_has_feature(&bts->features, i) != osmo_bts_has_feature(&bts->model->features, i)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18598">change 18598</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I40925ecc02ff94e510c04b048fe1bbc2066a7776 </div>
<div style="display:none"> Gerrit-Change-Number: 18598 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>