<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18527">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/L1CTL_Types: fix definition of L1ctlH1 (hopping parameters)<br><br>Change-Id: I87555de751e6e4af6ac5fe308c3e77fa15c8bb16<br>Related: OS#4546<br>---<br>M library/L1CTL_Types.ttcn<br>1 file changed, 13 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn</span><br><span>index 0870a20..38e4c15 100644</span><br><span>--- a/library/L1CTL_Types.ttcn</span><br><span>+++ b/library/L1CTL_Types.ttcn</span><br><span>@@ -290,13 +290,23 @@</span><br><span>               octetstring     l2_payload</span><br><span>   } with { variant "" };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  type record length(0..64) of Arfcn L1ctlMA;</span><br><span>  type record L1ctlH1 {</span><br><span>                uint8_t         hsn,</span><br><span>                 uint8_t         maio,</span><br><span>                uint8_t         n,</span><br><span style="color: hsl(0, 100%, 40%);">-              OCT1            padding,</span><br><span style="color: hsl(0, 100%, 40%);">-                bitstring       ma length(64)</span><br><span style="color: hsl(0, 100%, 40%);">-   } with { variant "" };</span><br><span style="color: hsl(120, 100%, 40%);">+              OCT1            spare,</span><br><span style="color: hsl(120, 100%, 40%);">+                L1ctlMA         ma,</span><br><span style="color: hsl(120, 100%, 40%);">+           octetstring     padding</span><br><span style="color: hsl(120, 100%, 40%);">+       } with {</span><br><span style="color: hsl(120, 100%, 40%);">+              variant (n) "LENGTHTO(ma)"</span><br><span style="color: hsl(120, 100%, 40%);">+          variant (n) "UNIT(elements)"</span><br><span style="color: hsl(120, 100%, 40%);">+                /* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562849.</span><br><span style="color: hsl(120, 100%, 40%);">+           * TL;DR The reference point of the PADDING attribute is the beginning</span><br><span style="color: hsl(120, 100%, 40%);">+                 * of the message, not the beginning of the type/field it's applied on.</span><br><span style="color: hsl(120, 100%, 40%);">+            * Therefore we cannot use it here, and have to add padding manually.</span><br><span style="color: hsl(120, 100%, 40%);">+          * variant (ma) "PADDING(128)" */</span><br><span style="color: hsl(120, 100%, 40%);">+   };</span><br><span> </span><br><span>       type record L1ctlDmEstReq {</span><br><span>          GsmTsc          tsc,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18527">change 18527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I87555de751e6e4af6ac5fe308c3e77fa15c8bb16 </div>
<div style="display:none"> Gerrit-Change-Number: 18527 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>