<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/18581">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix unreachable code (error msg on trunk alloc fail)<br><br>When a trunk is selected that does not exist, a new one is created. In<br>this case the VTY would print an error message but the function exits<br>early. The code that would print the error is unreachable.<br><br>Change-Id: Ie8c3b083174eb8209df2c06f65db6d7bbfaa87f7<br>fixes: CID#210637<br>---<br>M src/libosmo-mgcp/mgcp_vty.c<br>1 file changed, 4 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>index 6a431e5..bdcb55c 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_vty.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>@@ -813,14 +813,11 @@</span><br><span>     trunk = mgcp_trunk_num(g_cfg, index);</span><br><span>        if (!trunk) {</span><br><span>                trunk = mgcp_trunk_alloc(g_cfg, MGCP_TRUNK_E1, index);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!trunk)</span><br><span style="color: hsl(120, 100%, 40%);">+           if (!trunk) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 vty_out(vty, "%%Unable to allocate trunk %u.%s",</span><br><span style="color: hsl(120, 100%, 40%);">+                            index, VTY_NEWLINE);</span><br><span>                         return CMD_WARNING;</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!trunk) {</span><br><span style="color: hsl(0, 100%, 40%);">-           vty_out(vty, "%%Unable to allocate trunk %u.%s",</span><br><span style="color: hsl(0, 100%, 40%);">-                      index, VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-            return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>    }</span><br><span> </span><br><span>        vty->node = TRUNK_NODE;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/18581">change 18581</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/18581"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie8c3b083174eb8209df2c06f65db6d7bbfaa87f7 </div>
<div style="display:none"> Gerrit-Change-Number: 18581 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>