<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/cards.py">File pySim/cards.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/cards.py@a228">Patch Set #1, Line 228:</a> <code style="font-family:monospace,monospace">'3f00', '2f00'</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Are you sure about this change? It's not just '2f00', but with '3f00'.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">yes, that's taken from the EF, which ends up being<br>'DIR':    [MF_num, EF_num['DIR']]</p><p style="white-space: pre-wrap; word-wrap: break-word;">so just a cosmetic change</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/cards.py">File pySim/cards.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/cards.py@228">Patch Set #2, Line 228:</a> <code style="font-family:monospace,monospace">(EF['DIR'])</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Again, is this correct? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">EF['DIR'] is coming from here (ts_51_011.py)</p><p style="white-space: pre-wrap; word-wrap: break-word;">EF = {<br>'ICCID':  [MF_num, EF_num['ICCID']],<br>'ELP':    [MF_num, EF_num['ELP']],<br>'DIR':    [MF_num, EF_num['DIR']],</p><p style="white-space: pre-wrap; word-wrap: break-word;">which ends up being the same values (unless I am missing something else?)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_31_102.py">File pySim/ts_31_102.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_31_102.py@141">Patch Set #1, Line 141:</a> <code style="font-family:monospace,monospace">'LI': '6F05',</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Please align it with tabs: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/ts_31_102.py">File pySim/ts_31_102.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/2/pySim/ts_31_102.py@140">Patch Set #2, Line 140:</a> <code style="font-family:monospace,monospace">EF_ADF_map = {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">it would be great to have it renamed it as EF_USIM_ADF_map as there is also ISIM ADF as well. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">shoudln't that go in the other file, as it's in a different spec?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_51_011.py">File pySim/ts_51_011.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_51_011.py@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Unrelated change.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/18564">change 18564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/18564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I458380bf46b2986662ecdede2551c22cd9be92ba </div>
<div style="display:none"> Gerrit-Change-Number: 18564 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-CC: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 May 2020 12:32:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>