<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18357">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/IPA_Emulation: server mode: handle multiple client connections<br><br>This change basically does two simple things:<br><br>  a) adds TCP connection identifier to ASP_IPA_Event,<br>  b) splits g_ipa_conn_id into g_self_conn_id and g_last_conn_id.<br><br>Change a) would let the upper layers of code (based on the IPA<br>emulation component) know which TCP/IP connection a given event<br>belongs/relates to.<br><br>Change b) solves the problem, happening in server mode when a new<br>client connects, and TCP/IP connection identifier of another<br>previously connected client gets overwritten.<br><br>With this change applied, g_self_conn_id holds TCP/IP connection<br>identifier of the client or server itself (depending on g_mode),<br>while g_last_conn_id is only used in server mode and holds<br>connection identifier of the last connected client.<br><br>Change-Id: I93c58c08cf296e5cea81d811650caa1a09b8a579<br>Related: OS#4546<br>---<br>M library/IPA_Emulation.ttcnpp<br>1 file changed, 74 insertions(+), 41 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp</span><br><span>index 0125c3a..1833a89 100644</span><br><span>--- a/library/IPA_Emulation.ttcnpp</span><br><span>+++ b/library/IPA_Emulation.ttcnpp</span><br><span>@@ -84,16 +84,20 @@</span><br><span> </span><br><span> /* an event indicating us whether or not a connection is physically up or down,</span><br><span>  * and whether we have received an ID_ACK */</span><br><span style="color: hsl(0, 100%, 40%);">-type union ASP_IPA_Event {</span><br><span style="color: hsl(0, 100%, 40%);">-     ASP_IPA_EventType       up_down</span><br><span style="color: hsl(120, 100%, 40%);">+type record ASP_IPA_Event {</span><br><span style="color: hsl(120, 100%, 40%);">+  ASP_IPA_EventType       ev_type,</span><br><span style="color: hsl(120, 100%, 40%);">+      integer                 conn_id</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template (value) ASP_IPA_Event ts_ASP_IPA_EV(ASP_IPA_EventType ud) := {</span><br><span style="color: hsl(0, 100%, 40%);">- up_down := ud</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) ASP_IPA_Event ts_ASP_IPA_EV(ASP_IPA_EventType ev_type, integer conn_id) := {</span><br><span style="color: hsl(120, 100%, 40%);">+  ev_type := ev_type,</span><br><span style="color: hsl(120, 100%, 40%);">+   conn_id := conn_id</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template ASP_IPA_Event tr_ASP_IPA_EV(template ASP_IPA_EventType ud) := {</span><br><span style="color: hsl(0, 100%, 40%);">-     up_down := ud</span><br><span style="color: hsl(120, 100%, 40%);">+template ASP_IPA_Event tr_ASP_IPA_EV(template ASP_IPA_EventType ev_type,</span><br><span style="color: hsl(120, 100%, 40%);">+                                    template integer conn_id := ?) := {</span><br><span style="color: hsl(120, 100%, 40%);">+      ev_type := ev_type,</span><br><span style="color: hsl(120, 100%, 40%);">+   conn_id := conn_id</span><br><span> }</span><br><span> </span><br><span> template ASP_IPA_Unitdata t_ASP_IPA_UD(IpaStreamId sid, octetstring pl,</span><br><span>@@ -212,10 +216,14 @@</span><br><span>       port IPA_SP_PT IPA_SP_PORT;</span><br><span> </span><br><span>      var boolean g_initialized := false;</span><br><span style="color: hsl(0, 100%, 40%);">-     var IPL4asp_Types.ConnectionId g_ipa_conn_id := -1;</span><br><span>  /* Are we a BSC/MGW (truel) or MSC (false) */</span><br><span>        var boolean g_is_bsc_mgw;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Connection identifier of the client / server itself */</span><br><span style="color: hsl(120, 100%, 40%);">+     var IPL4asp_Types.ConnectionId g_self_conn_id := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Connection identifier of the last connected client (server only) */</span><br><span style="color: hsl(120, 100%, 40%);">+        var IPL4asp_Types.ConnectionId g_last_conn_id := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       var IpaMode g_mode;</span><br><span>  var boolean g_ccm_enabled;</span><br><span>   var IpaInitBehavior g_init_behavior;</span><br><span>@@ -260,7 +268,7 @@</span><br><span>                      " to ", remote_host, " port ", remote_port, "; check your configuration");</span><br><span>          mtc.stop;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       g_ipa_conn_id := res.connId;</span><br><span style="color: hsl(120, 100%, 40%);">+  g_self_conn_id := res.connId;</span><br><span>        g_ccm_pars := ccm_pars;</span><br><span>      g_is_bsc_mgw := true;</span><br><span> }</span><br><span>@@ -275,7 +283,7 @@</span><br><span>             setverdict(fail, "Could not listen IPA socket ", local_host, ":", local_port, ", check your configuration");</span><br><span>           mtc.stop;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       g_ipa_conn_id := res.connId;</span><br><span style="color: hsl(120, 100%, 40%);">+  g_self_conn_id := res.connId;</span><br><span>        g_ccm_pars := ccm_pars;</span><br><span>      g_is_bsc_mgw := false;</span><br><span> }</span><br><span>@@ -384,8 +392,9 @@</span><br><span> }</span><br><span> </span><br><span> /* transmit IPA CCM message */</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_ccm_tx(PDU_IPA_CCM ccm) runs on IPA_Emulation_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-       var IPA_Send ipa_tx := valueof(t_IPA_Send(g_ipa_conn_id, IPAC_PROTO_CCM, enc_PDU_IPA_CCM(ccm)));</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_ccm_tx(PDU_IPA_CCM ccm, IPL4asp_Types.ConnectionId conn_id)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on IPA_Emulation_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+  var IPA_Send ipa_tx := valueof(t_IPA_Send(conn_id, IPAC_PROTO_CCM, enc_PDU_IPA_CCM(ccm)));</span><br><span>   log("CCM Tx:", ccm);</span><br><span>       IPA_PORT.send(ipa_tx);</span><br><span> }</span><br><span>@@ -413,13 +422,13 @@</span><br><span> private function f_ccm_rx_client(PDU_IPA_CCM ccm) runs on IPA_Emulation_CT {</span><br><span>  select (ccm.msg_type) {</span><br><span>              case (IPAC_MSGT_PING) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 f_ccm_tx(valueof(ts_IPA_PONG));</span><br><span style="color: hsl(120, 100%, 40%);">+                       f_ccm_tx(valueof(ts_IPA_PONG), g_self_conn_id);</span><br><span>              }</span><br><span>            case (IPAC_MSGT_ID_ACK) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK));</span><br><span style="color: hsl(120, 100%, 40%);">+                  f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK, g_self_conn_id));</span><br><span>                 }</span><br><span>            case (IPAC_MSGT_ID_GET) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       f_ccm_tx(f_ccm_make_id_resp(ccm));</span><br><span style="color: hsl(120, 100%, 40%);">+                    f_ccm_tx(f_ccm_make_id_resp(ccm), g_self_conn_id);</span><br><span>           }</span><br><span>            case else {</span><br><span>                  log("Unknown/unsupported IPA CCM message type", ccm);</span><br><span>@@ -427,10 +436,11 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_ccm_rx_server(PDU_IPA_CCM ccm) runs on IPA_Emulation_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_ccm_rx_server(PDU_IPA_CCM ccm, IPL4asp_Types.ConnectionId conn_id)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on IPA_Emulation_CT {</span><br><span>    select (ccm.msg_type) {</span><br><span>              case (IPAC_MSGT_PING) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 f_ccm_tx(valueof(ts_IPA_PONG));</span><br><span style="color: hsl(120, 100%, 40%);">+                       f_ccm_tx(valueof(ts_IPA_PONG), conn_id);</span><br><span>             }</span><br><span>            case (IPAC_MSGT_ID_ACK) {</span><br><span>                    /* the IPA server should at some point receive an ID_ACK from the client,</span><br><span>@@ -438,12 +448,12 @@</span><br><span>                     * the TCP connection is established.  Other implementations may differ.</span><br><span>                      * We currently ignore it completely - but actually we should make sure that</span><br><span>                          * one ID_ACK is received by the server at some point */</span><br><span style="color: hsl(0, 100%, 40%);">-                        f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK));</span><br><span style="color: hsl(120, 100%, 40%);">+                  f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK, conn_id));</span><br><span>                }</span><br><span>            case (IPAC_MSGT_ID_RESP) {</span><br><span>                   log("IPA ID RESP: ", ccm.u.resp);</span><br><span>                  /* acknowledge any identity that the client may have sent */</span><br><span style="color: hsl(0, 100%, 40%);">-                    f_ccm_tx(valueof(ts_IPA_ACK));</span><br><span style="color: hsl(120, 100%, 40%);">+                        f_ccm_tx(valueof(ts_IPA_ACK), conn_id);</span><br><span>              }</span><br><span>            case else {</span><br><span>                  log("Unknown/unsupported IPA CCM message type", ccm);</span><br><span>@@ -492,9 +502,9 @@</span><br><span>        f_connect(remote_host, remote_port, local_host, local_port, ccm_pars);</span><br><span>       if (g_ccm_enabled) {</span><br><span>                 /* we're a client: Send ID_ACK immediately after connect */</span><br><span style="color: hsl(0, 100%, 40%);">-         f_ccm_tx(valueof(ts_IPA_ACK));</span><br><span style="color: hsl(120, 100%, 40%);">+                f_ccm_tx(valueof(ts_IPA_ACK), g_self_conn_id);</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-       f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_UP));</span><br><span style="color: hsl(120, 100%, 40%);">+      f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_UP, g_self_conn_id));</span><br><span>     ScanEvents();</span><br><span> }</span><br><span> </span><br><span>@@ -553,6 +563,28 @@</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Resolve TCP/IP connection identifier depending on g_mode */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_ipa_conn_id() runs on IPA_Emulation_CT</span><br><span style="color: hsl(120, 100%, 40%);">+return IPL4asp_Types.ConnectionId {</span><br><span style="color: hsl(120, 100%, 40%);">+      var IPL4asp_Types.ConnectionId conn_id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     select (g_mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+     case (IPA_MODE_CLIENT) { conn_id := g_self_conn_id; }</span><br><span style="color: hsl(120, 100%, 40%);">+ case (IPA_MODE_SERVER) { conn_id := g_last_conn_id; }</span><br><span style="color: hsl(120, 100%, 40%);">+ case else {</span><br><span style="color: hsl(120, 100%, 40%);">+           setverdict(fail, "Unknown mode");</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (conn_id == -1) { /* Just to be sure */</span><br><span style="color: hsl(120, 100%, 40%);">+            setverdict(fail, "Connection is not established");</span><br><span style="color: hsl(120, 100%, 40%);">+          mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   return conn_id;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* main loop function for both client and server. 'thread' of the component */</span><br><span> private function ScanEvents() runs on IPA_Emulation_CT {</span><br><span>   var IPA_RecvFrom ipa_rx;</span><br><span>@@ -585,7 +617,7 @@</span><br><span> </span><br><span>   /* Set function for dissecting the binary */</span><br><span>         var f_IPL4_getMsgLen vl_f := refers(f_IPL4_fixedMsgLen);</span><br><span style="color: hsl(0, 100%, 40%);">-        IPA_CodecPort_CtrlFunct.f_IPL4_setGetMsgLen(IPA_PORT, g_ipa_conn_id, vl_f, {0, 2, 3, 1, 0});</span><br><span style="color: hsl(120, 100%, 40%);">+  IPA_CodecPort_CtrlFunct.f_IPL4_setGetMsgLen(IPA_PORT, g_self_conn_id, vl_f, {0, 2, 3, 1, 0});</span><br><span> </span><br><span>    while (true) {</span><br><span>               alt {</span><br><span>@@ -598,7 +630,7 @@</span><br><span>                                  f_ccm_rx_client(ccm);</span><br><span>                                }</span><br><span>                            case (IPA_MODE_SERVER) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                        f_ccm_rx_server(ccm);</span><br><span style="color: hsl(120, 100%, 40%);">+                                 f_ccm_rx_server(ccm, ipa_rx.connId);</span><br><span>                                 }</span><br><span>                            case else {</span><br><span>                                  setverdict(fail, "Unknown mode");</span><br><span>@@ -670,16 +702,17 @@</span><br><span> </span><br><span>              /* server only */</span><br><span>            [] IPA_PORT.receive(ASP_Event:{connOpened:=?}) -> value asp_evt {</span><br><span style="color: hsl(0, 100%, 40%);">-                    log("IPA: Connected");</span><br><span style="color: hsl(0, 100%, 40%);">-                        g_ipa_conn_id := asp_evt.connOpened.connId;</span><br><span style="color: hsl(0, 100%, 40%);">-                     f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_UP));</span><br><span style="color: hsl(120, 100%, 40%);">+                      g_last_conn_id := asp_evt.connOpened.connId;</span><br><span style="color: hsl(120, 100%, 40%);">+                  log("Established a new IPA connection (conn_id=", g_last_conn_id, ")");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                 f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_UP, g_last_conn_id));</span><br><span>                     if (g_mode == IPA_MODE_SERVER and g_ccm_enabled) {</span><br><span>                           select (g_init_behavior) {</span><br><span>                                   case (IPA_INIT_SEND_IPA_ID_GET) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                               f_ccm_tx(valueof(ts_IPA_ID_GET));</span><br><span style="color: hsl(120, 100%, 40%);">+                                             f_ccm_tx(valueof(ts_IPA_ID_GET), g_last_conn_id);</span><br><span>                                    }</span><br><span>                                    case (IPA_INIT_SEND_IPA_ID_ACK) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                               f_ccm_tx(valueof(ts_IPA_ACK));</span><br><span style="color: hsl(120, 100%, 40%);">+                                                f_ccm_tx(valueof(ts_IPA_ACK), g_last_conn_id);</span><br><span>                                       }</span><br><span>                            }</span><br><span>                    }</span><br><span>@@ -687,22 +720,22 @@</span><br><span> </span><br><span>                [] IPA_PORT.receive(ASP_Event:{connClosed:=?}) -> value asp_evt {</span><br><span>                         log("IPA: Closed");</span><br><span style="color: hsl(0, 100%, 40%);">-                   g_ipa_conn_id := -1;</span><br><span style="color: hsl(0, 100%, 40%);">-                    f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_DOWN));</span><br><span style="color: hsl(120, 100%, 40%);">+                    g_self_conn_id := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+                 f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_DOWN, asp_evt.connClosed.connId));</span><br><span>                        self.stop;</span><br><span>           }</span><br><span> </span><br><span>                [] IPA_PORT.receive(Socket_API_Definitions.PortEvent:{result:={errorCode:=ERROR_SOCKET, connId:=?, os_error_code:=?, os_error_text:=?}}) -> value port_evt {</span><br><span>                      log("PortEvent: ERROR_SOCKET: ", port_evt);</span><br><span style="color: hsl(0, 100%, 40%);">-                   g_ipa_conn_id := -1;</span><br><span style="color: hsl(0, 100%, 40%);">-                    f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_DOWN));</span><br><span style="color: hsl(120, 100%, 40%);">+                    g_self_conn_id := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+                 f_send_IPA_EVT(ts_ASP_IPA_EV(ASP_IPA_EVENT_DOWN, port_evt.result.connId));</span><br><span>                   self.stop;</span><br><span>           }</span><br><span> </span><br><span> #ifdef IPA_EMULATION_SCCP</span><br><span>           /* Received SCCP -> down into IPA */</span><br><span>              [] MTP3_SP_PORT.receive(ASP_MTP3_TRANSFERreq: ?) -> value mtp_req {</span><br><span style="color: hsl(0, 100%, 40%);">-                  var IPA_Send ipa_tx := valueof(t_IPA_Send(g_ipa_conn_id, IPAC_PROTO_SCCP,</span><br><span style="color: hsl(120, 100%, 40%);">+                     var IPA_Send ipa_tx := valueof(t_IPA_Send(f_ipa_conn_id(), IPAC_PROTO_SCCP,</span><br><span>                                                  mtp_req.data));</span><br><span>                      IPA_PORT.send(ipa_tx);</span><br><span>               }</span><br><span>@@ -713,12 +746,12 @@</span><br><span>            [] IPA_MGCP_PORT.receive(MgcpCommand:?) -> value mgcp_cmd {</span><br><span>                       payload := char2oct(enc_MgcpCommand(mgcp_cmd));</span><br><span>                      ipa_ud := f_mgcp_to_ud(payload);</span><br><span style="color: hsl(0, 100%, 40%);">-                        IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span>            [] IPA_MGCP_PORT.receive(MgcpResponse:?) -> value mgcp_rsp {</span><br><span>                      payload := char2oct(enc_MgcpResponse(mgcp_rsp));</span><br><span>                     ipa_ud := f_mgcp_to_ud(payload);</span><br><span style="color: hsl(0, 100%, 40%);">-                        IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span> #endif</span><br><span> </span><br><span>@@ -726,7 +759,7 @@</span><br><span>                [] IPA_CTRL_PORT.receive(CtrlMessage:?) -> value ctrl_msg {</span><br><span>                       payload := char2oct(enc_CtrlMessage(ctrl_msg));</span><br><span>                      ipa_ud := valueof(t_ASP_IPA_UD(IPAC_PROTO_OSMO, payload, IPAC_PROTO_EXT_CTRL));</span><br><span style="color: hsl(0, 100%, 40%);">-                 IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span> #endif</span><br><span> </span><br><span>@@ -735,7 +768,7 @@</span><br><span>                        f_gsup_preprocess_encoded(gsup_msg);</span><br><span>                         payload := enc_GSUP_PDU(gsup_msg);</span><br><span>                   ipa_ud := valueof(t_ASP_IPA_UD(IPAC_PROTO_OSMO, payload, IPAC_PROTO_EXT_GSUP));</span><br><span style="color: hsl(0, 100%, 40%);">-                 IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span> #endif</span><br><span> </span><br><span>@@ -743,28 +776,28 @@</span><br><span>              [] IPA_RSPRO_PORT.receive(RsproPDU:?) -> value rspro {</span><br><span>                    payload := enc_RsproPDU(rspro);</span><br><span>                      ipa_ud := valueof(t_ASP_IPA_UD(IPAC_PROTO_OSMO, payload, IPAC_PROTO_EXT_RSPRO));</span><br><span style="color: hsl(0, 100%, 40%);">-                        IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span> #endif</span><br><span> </span><br><span> #ifdef IPA_EMULATION_RSL</span><br><span>          /* Received RSL -> down into IPA */</span><br><span>               [] IPA_RSL_PORT.receive(ASP_RSL_Unitdata:?) -> value rsl {</span><br><span style="color: hsl(0, 100%, 40%);">-                   IPA_PORT.send(f_from_rsl(g_ipa_conn_id, rsl));</span><br><span style="color: hsl(120, 100%, 40%);">+                        IPA_PORT.send(f_from_rsl(f_ipa_conn_id(), rsl));</span><br><span>             }</span><br><span> #endif</span><br><span> #ifdef IPA_EMULATION_OML</span><br><span>              /* Received OML -> down into IPA */</span><br><span>               [] IPA_OML_PORT.receive(OML_PDU:?) -> value oml {</span><br><span style="color: hsl(0, 100%, 40%);">-                    IPA_PORT.send(f_from_oml(g_ipa_conn_id, oml));</span><br><span style="color: hsl(120, 100%, 40%);">+                        IPA_PORT.send(f_from_oml(f_ipa_conn_id(), oml));</span><br><span>             }</span><br><span>            [] IPA_OML_PORT.receive(octetstring:?) -> value payload {</span><br><span style="color: hsl(0, 100%, 40%);">-                    IPA_PORT.send(t_IPA_Send(g_ipa_conn_id, IPAC_PROTO_OML, payload));</span><br><span style="color: hsl(120, 100%, 40%);">+                    IPA_PORT.send(t_IPA_Send(f_ipa_conn_id(), IPAC_PROTO_OML, payload));</span><br><span>                 }</span><br><span> #endif</span><br><span>          /* Received MISC (OML/CTRL) -> down into IPA */</span><br><span>           [] IPA_SP_PORT.receive(ASP_IPA_Unitdata: ?) -> value ipa_ud {</span><br><span style="color: hsl(0, 100%, 40%);">-                        IPA_PORT.send(f_from_asp(g_ipa_conn_id, ipa_ud));</span><br><span style="color: hsl(120, 100%, 40%);">+                     IPA_PORT.send(f_from_asp(f_ipa_conn_id(), ipa_ud));</span><br><span>          }</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18357">change 18357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93c58c08cf296e5cea81d811650caa1a09b8a579 </div>
<div style="display:none"> Gerrit-Change-Number: 18357 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>