<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18501">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CTRL: determine MSC connection status from RESET-ACK, not AS_ACTIVE<br><br>Change-Id: I264ba6a72ea93297cfbc99602eccfbf4a890f703<br>---<br>M src/osmo-bsc/osmo_bsc_ctrl.c<br>1 file changed, 4 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/18501/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>index 12b2f4d..a787962 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>@@ -26,6 +26,7 @@</span><br><span> #include <osmocom/bsc/osmo_bsc_rf.h></span><br><span> #include <osmocom/bsc/bsc_msc_data.h></span><br><span> #include <osmocom/bsc/signal.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/a_reset.h></span><br><span> </span><br><span> #include <osmocom/core/linuxlist.h></span><br><span> #include <osmocom/core/signal.h></span><br><span>@@ -179,24 +180,15 @@</span><br><span> static int get_msc_connection_status(struct ctrl_cmd *cmd, void *data)</span><br><span> {</span><br><span>         struct bsc_msc_data *msc = (struct bsc_msc_data *)cmd->node;</span><br><span style="color: hsl(0, 100%, 40%);">- struct osmo_ss7_as *as;</span><br><span style="color: hsl(0, 100%, 40%);">- const char *as_state_name;</span><br><span> </span><br><span>       if (msc == NULL) {</span><br><span>           cmd->reply = "msc not found";</span><br><span>           return CTRL_CMD_ERROR;</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-       as = msc_get_ss7_as(msc);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!as) {</span><br><span style="color: hsl(0, 100%, 40%);">-              cmd->reply = "AS not found for MSC";</span><br><span style="color: hsl(0, 100%, 40%);">-               return CTRL_CMD_ERROR;</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       as_state_name = osmo_fsm_inst_state_name(as->fi);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!strcmp(as_state_name, "AS_ACTIVE"))</span><br><span style="color: hsl(0, 100%, 40%);">-              cmd->reply = "connected";</span><br><span style="color: hsl(0, 100%, 40%);">-  else</span><br><span style="color: hsl(120, 100%, 40%);">+  if (a_reset_conn_ready(msc))</span><br><span>                 cmd->reply = "disconnected";</span><br><span style="color: hsl(120, 100%, 40%);">+     else</span><br><span style="color: hsl(120, 100%, 40%);">+          cmd->reply = "connected";</span><br><span>       return CTRL_CMD_REPLY;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18501">change 18501</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I264ba6a72ea93297cfbc99602eccfbf4a890f703 </div>
<div style="display:none"> Gerrit-Change-Number: 18501 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>