<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18434">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible<br><br>Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b<br>---<br>M src/encoding.cpp<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/34/18434/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 1805645..cb89b01 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -197,7 +197,8 @@</span><br><span>         CHECK(rc);</span><br><span> </span><br><span>       /* RLC acknowledged mode */</span><br><span style="color: hsl(0, 100%, 40%);">-     SET_0(dest); /* RLC_MODE */</span><br><span style="color: hsl(120, 100%, 40%);">+   rc = bitvec_set_bit(dest, (bit_value) RLC_MODE_ACKNOWLEDGED);</span><br><span style="color: hsl(120, 100%, 40%);">+ CHECK(rc);</span><br><span> </span><br><span>       rc = write_alpha_gamma(dest, alpha, gamma);</span><br><span>  CHECK(rc);</span><br><span>@@ -668,7 +669,7 @@</span><br><span>     }</span><br><span> </span><br><span>        block->u.Packet_Downlink_Assignment.MAC_MODE            = 0x0;          // Dynamic Allocation</span><br><span style="color: hsl(0, 100%, 40%);">-        block->u.Packet_Downlink_Assignment.RLC_MODE            = 0x0;          // RLC acknowledged mode</span><br><span style="color: hsl(120, 100%, 40%);">+   block->u.Packet_Downlink_Assignment.RLC_MODE            = RLC_MODE_ACKNOWLEDGED;</span><br><span>  block->u.Packet_Downlink_Assignment.CONTROL_ACK         = tbf->was_releasing; // NW establishes no new DL TBF for the MS with running timer T3192</span><br><span>      block->u.Packet_Downlink_Assignment.TIMESLOT_ALLOCATION = 0;   // timeslot(s)</span><br><span>     for (tn = 0; tn < 8; tn++) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18434">change 18434</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/18434"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b </div>
<div style="display:none"> Gerrit-Change-Number: 18434 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>