<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18397">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit: cosmetic: get rid of 'i' where it is not used<br><br>Change-Id: I00126a90446e5f3fb77a46be9d7d5dbff89fa221<br>---<br>M src/target/trx_toolkit/data_dump.py<br>M src/target/trx_toolkit/data_msg.py<br>M src/target/trx_toolkit/rand_burst_gen.py<br>M src/target/trx_toolkit/test_data_dump.py<br>4 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/18397/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py</span><br><span>index 41af695..52768a9 100644</span><br><span>--- a/src/target/trx_toolkit/data_dump.py</span><br><span>+++ b/src/target/trx_toolkit/data_dump.py</span><br><span>@@ -98,7 +98,7 @@</span><br><span>           self.f.seek(0)</span><br><span> </span><br><span>           # Read the capture in loop...</span><br><span style="color: hsl(0, 100%, 40%);">-           for i in range(idx):</span><br><span style="color: hsl(120, 100%, 40%);">+          for _ in range(idx):</span><br><span>                         # Attempt to read a message header</span><br><span>                   hdr_raw = self.f.read(self.HDR_LENGTH)</span><br><span>                       if len(hdr_raw) != self.HDR_LENGTH:</span><br><span>diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py</span><br><span>index 35e09d6..55fb796 100644</span><br><span>--- a/src/target/trx_toolkit/data_msg.py</span><br><span>+++ b/src/target/trx_toolkit/data_msg.py</span><br><span>@@ -403,7 +403,7 @@</span><br><span> </span><br><span>   # Generate a random message specific burst</span><br><span>   def rand_burst(self, length = GSM_BURST_LEN):</span><br><span style="color: hsl(0, 100%, 40%);">-           self.burst = [random.randint(0, 1) for i in range(length)]</span><br><span style="color: hsl(120, 100%, 40%);">+            self.burst = [random.randint(0, 1) for _ in range(length)]</span><br><span> </span><br><span>       # Transforms this message to TRX2L1 message</span><br><span>  def gen_trx2l1(self, ver = None):</span><br><span>@@ -812,7 +812,7 @@</span><br><span>              if length is None:</span><br><span>                   length = self.mod_type.bl</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           self.burst = [random.randint(-127, 127) for i in range(length)]</span><br><span style="color: hsl(120, 100%, 40%);">+               self.burst = [random.randint(-127, 127) for _ in range(length)]</span><br><span> </span><br><span>  # Transforms this message to L12TRX message</span><br><span>  def gen_l12trx(self, ver = None):</span><br><span>diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>index a56467f..9ac6943 100644</span><br><span>--- a/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>+++ b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>@@ -57,7 +57,7 @@</span><br><span>           buf += [0] * 3</span><br><span> </span><br><span>           # Random data 1 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             buf += [random.randint(0, 1) for i in range(57)]</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for _ in range(57)]</span><br><span> </span><br><span>                 # Steal flag 1 / 2</span><br><span>           buf.append(random.randint(0, 1))</span><br><span>@@ -71,7 +71,7 @@</span><br><span>                 buf.append(random.randint(0, 1))</span><br><span> </span><br><span>                 # Random data 2 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             buf += [random.randint(0, 1) for i in range(57)]</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for _ in range(57)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span>@@ -90,7 +90,7 @@</span><br><span>           buf += [0] * 3</span><br><span> </span><br><span>           # Random data 1 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             buf += [random.randint(0, 1) for i in range(39)]</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for _ in range(39)]</span><br><span> </span><br><span>                 # Training sequence</span><br><span>          if tsc is None:</span><br><span>@@ -98,7 +98,7 @@</span><br><span>          buf += tsc.seq</span><br><span> </span><br><span>           # Random data 2 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             buf += [random.randint(0, 1) for i in range(39)]</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for _ in range(39)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span>@@ -122,7 +122,7 @@</span><br><span>                 buf += tsc.seq</span><br><span> </span><br><span>           # Random data</span><br><span style="color: hsl(0, 100%, 40%);">-           buf += [random.randint(0, 1) for i in range(36)]</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for _ in range(36)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span>diff --git a/src/target/trx_toolkit/test_data_dump.py b/src/target/trx_toolkit/test_data_dump.py</span><br><span>index 5129196..9cd9b79 100644</span><br><span>--- a/src/target/trx_toolkit/test_data_dump.py</span><br><span>+++ b/src/target/trx_toolkit/test_data_dump.py</span><br><span>@@ -79,7 +79,7 @@</span><br><span>      def _gen_rand_messages(self, cls, count, ver = 1):</span><br><span>           msg_list = []</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               for i in range(count):</span><br><span style="color: hsl(120, 100%, 40%);">+                for _ in range(count):</span><br><span>                       msg = self._gen_rand_message(cls, ver)</span><br><span>                       msg_list.append(msg)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18397">change 18397</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18397"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00126a90446e5f3fb77a46be9d7d5dbff89fa221 </div>
<div style="display:none"> Gerrit-Change-Number: 18397 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>