<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/18395">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Log when sending of CLK indications begins<br><br>When the logging category TRXCLK is set to info osmo-trx prints a<br>logline that informs about the sending of clock indications. In practice<br>this those log lines are often used to identify that osmo-trx and<br>osmo-bts are running properly, so it would be helpful, even in<br>productive use, if there would be an information in the log that the<br>sending of clock indications has begun. However, the regular printing of<br>the clock indication log line would soon flood the log. So, lets have an<br>addional log line that logs only once when the transceiver starts and<br>quickly informs at loglevel NOTICE that clock indications are now sent.<br><br>Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a<br>Related: OS#2577<br>---<br>M Transceiver52M/Transceiver.cpp<br>M Transceiver52M/Transceiver.h<br>2 files changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/18395/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index d9bda1d..1af3e15 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -278,6 +278,8 @@</span><br><span> {</span><br><span>   ScopedLock lock(mLock);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  mClkIndSent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   if (mOn) {</span><br><span>     LOG(ERR) << "Transceiver already running";</span><br><span>     return true;</span><br><span>@@ -1166,7 +1168,11 @@</span><br><span> {</span><br><span>   int msgLen;</span><br><span>   char command[50];</span><br><span style="color: hsl(0, 100%, 40%);">-  // FIXME -- This should be adaptive.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!mClkIndSent)</span><br><span style="color: hsl(120, 100%, 40%);">+    LOGC(DTRXCLK, NOTICE) << "Sending CLOCK indications";</span><br><span style="color: hsl(120, 100%, 40%);">+  mClkIndSent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   sprintf(command,"IND CLOCK %llu",(unsigned long long) (mTransmitDeadlineClock.FN()+2));</span><br><span> </span><br><span>   LOGC(DTRXCLK, INFO) << "sending " << command;</span><br><span>diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h</span><br><span>index 6e0d157..99d5b6c 100644</span><br><span>--- a/Transceiver52M/Transceiver.h</span><br><span>+++ b/Transceiver52M/Transceiver.h</span><br><span>@@ -273,6 +273,10 @@</span><br><span>   void reset();</span><br><span> </span><br><span>   void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Needed for logging only */</span><br><span style="color: hsl(120, 100%, 40%);">+  bool mClkIndSent;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> };</span><br><span> </span><br><span> void *RxUpperLoopAdapter(TrxChanThParams *params);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/18395">change 18395</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/18395"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a </div>
<div style="display:none"> Gerrit-Change-Number: 18395 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>