<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18267">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">virtual/scheduler: log unknown GSMTAP chan<br><br>Related change in libosmocore will let gsmtap_makemsg return NULL if the<br>channel type is unknown: Ib4147a33a75c3cf425c30da8b0678c7fba8a371d<br><br>Related: SYS#4822<br>Change-Id: Ic22ab71e520ab44429a93724250d349d16250801<br>---<br>M src/osmo-bts-virtual/scheduler_virtbts.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>index a60c9e0..eabd23b 100644</span><br><span>--- a/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>+++ b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>@@ -78,6 +78,10 @@</span><br><span>   else</span><br><span>                 gsmtap_chantype = chantype_rsl2gsmtap2(rsl_chantype, chdesc->link_id, is_voice_frame); /* the logical channel type */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  if (gsmtap_chantype == GSMTAP_CHANNEL_UNKNOWN)</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "Tx GSMTAP for RSL channel type 0x%02x: cannot send, this"</span><br><span style="color: hsl(120, 100%, 40%);">+                     " channel type is unknown in GSMTAP\n", rsl_chantype);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if MODULO_HYPERFRAME</span><br><span>   /* Restart fn after every superframe (26 * 51 frames) to simulate hyperframe overflow each 6 seconds. */</span><br><span>     fn %= 26 * 51;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18267">change 18267</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18267"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic22ab71e520ab44429a93724250d349d16250801 </div>
<div style="display:none"> Gerrit-Change-Number: 18267 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Assignee: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>