<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn">File pcu/GPRS_Components.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@a235">Patch Set #1, Line 235:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* 3GPP TS 44.018, table 9.1.8.1, note 2b: Request Reference shall be set to 127<br> * when Immediate Assignment is triggered by EGPRS Packet Channel Request. Here<br> * we assume that 11 bit RA always contains EGPRS Packet Channel Request. */<br> if (is_11bit != 0) { ra := 127; }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should have not been removed. That's why the related test cases fail.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">So what's the point then for tests TC_egprs_pkt_chan_req*() crafting ra values if finally this value 127 is set? Please enlighten me. To me either this or all those tests are wrong.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@48">Patch Set #1, Line 48:</a> <code style="font-family:monospace,monospace">GsmRrMessage</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Do we really need to store the RR Immediate Assignment in a TBF record? As far as I understand, we p […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We parse most relevant and usually used stuff like TFI, USF,etc. but for some stuff which we scarcely use it makes sense to keep rr_imm_ass, even if it's only for quick testing and test addition.<br>IIRC I stored it here because some test required something from rr_imm_ass, so it doesn't hurt that much keeping it for now. We may remove it later if we move all the contents to some other specific fields.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@49">Patch Set #1, Line 49:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PacketDlAssign ass,<br> PacketDlAssignment rlcmac_ass,<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Please add a couple of comments here, what is the difference between both? If I understand correctly […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes it serves the purpose you said.<br>Ok, I can move it to a union "ass" and then have "ass.ccch" and "ass.pacch"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@66">Patch Set #1, Line 66:</a> <code style="font-family:monospace,monospace">GprsTlli tlli</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">minor whitespace</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@72">Patch Set #1, Line 72:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UlTbf ul_tbf optional,<br> DlTbf dl_tbf optional<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Please add a comment that there can be more than one UL/DL TBF.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@111">Patch Set #1, Line 111:</a> <code style="font-family:monospace,monospace">f_init_gprs_ms</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This function looks redundant. Just let test cases evaluate t_GprsMS_def as they need. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Well, so far it only does that, but we may add new stuff here in the future, so I prefer keeping it this way for now, in case we have to init something component related at some point.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@239">Patch Set #1, Line 239:</a> <code style="font-family:monospace,monospace">f_ms_set_lqual</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This functions is redundant.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's like usual discussion on wheter setters are required or not for class attributes. I find it useful because grepping for the function name I can find all places where lqual is being set. Similar, in the future we can add new APIs to set if in dB, etc.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@244">Patch Set #1, Line 244:</a> <code style="font-family:monospace,monospace">f_ms_set_ta</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I am sorry, but it looks like f_sum(a, b) { return a + b } to me.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Again, I find it useful to quickly find where the TA field is being set, and make sure we always do it in a unified way.<br>I want to have as much logic as possible wrapped in this class.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370">change 18370</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288 </div>
<div style="display:none"> Gerrit-Change-Number: 18370 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 May 2020 11:00:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>