<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
neels: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Add a BTS/BSC counter PAGING_NO_ACTIVE_PAGING.<br><br>This is a corner case but still we should count the events to<br>know when is this happening. And for the number of paging requests<br>to match the number of paging responses.<br><br>Change-Id: I1755be40d29980b75353cb4b8087d1ce0d92854a<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/gsm_08_08.c<br>2 files changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 276fc02..a2e103d 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1412,6 +1412,7 @@</span><br><span> BTS_CTR_PAGING_ALREADY,</span><br><span> BTS_CTR_PAGING_RESPONDED,</span><br><span> BTS_CTR_PAGING_EXPIRED,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_CTR_PAGING_NO_ACTIVE_PAGING,</span><br><span> BTS_CTR_CHAN_ACT_TOTAL,</span><br><span> BTS_CTR_CHAN_ACT_NACK,</span><br><span> BTS_CTR_RSL_UNKNOWN,</span><br><span>@@ -1457,6 +1458,7 @@</span><br><span> [BTS_CTR_PAGING_ALREADY] = {"paging:already", "Paging attempts ignored as subscriber was already being paged."},</span><br><span> [BTS_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful paging response."},</span><br><span> [BTS_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging Request expired because of timeout T3113."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)."},</span><br><span> [BTS_CTR_CHAN_ACT_TOTAL] = {"chan_act:total", "Total number of Channel Activations."},</span><br><span> [BTS_CTR_CHAN_ACT_NACK] = {"chan_act:nack", "Number of Channel Activations that the BTS NACKed"},</span><br><span> [BTS_CTR_RSL_UNKNOWN] = {"rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS"},</span><br><span>@@ -1552,6 +1554,7 @@</span><br><span> BSC_CTR_PAGING_ATTEMPTED,</span><br><span> BSC_CTR_PAGING_DETACHED,</span><br><span> BSC_CTR_PAGING_RESPONDED,</span><br><span style="color: hsl(120, 100%, 40%);">+ BSC_CTR_PAGING_NO_ACTIVE_PAGING,</span><br><span> BSC_CTR_UNKNOWN_UNIT_ID,</span><br><span> };</span><br><span> </span><br><span>@@ -1596,6 +1599,7 @@</span><br><span> [BSC_CTR_PAGING_ATTEMPTED] = {"paging:attempted", "Paging attempts for a subscriber."},</span><br><span> [BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging request send failures because no responsible BTS was found."},</span><br><span> [BSC_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful response."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)."},</span><br><span> </span><br><span> [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID."},</span><br><span> };</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 4f9c69e..8a4b1c5 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -388,6 +388,8 @@</span><br><span> </span><br><span> if (!subscr) {</span><br><span> LOGP(DMSC, LOGL_ERROR, "Non active subscriber got paged.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&conn->lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&conn->network->bsc_ctrs->ctr[BSC_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332">change 18332</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1755be40d29980b75353cb4b8087d1ce0d92854a </div>
<div style="display:none"> Gerrit-Change-Number: 18332 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>