<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18339">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  neels: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">borken: Recover from more TS borken states.<br><br>Change-Id: Ic87c325a73690ede1b81b4d33bac65a1a4beea2d<br>---<br>M src/osmo-bsc/timeslot_fsm.c<br>1 file changed, 16 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c</span><br><span>index f8adfb6..84ffb7f 100644</span><br><span>--- a/src/osmo-bsc/timeslot_fsm.c</span><br><span>+++ b/src/osmo-bsc/timeslot_fsm.c</span><br><span>@@ -669,9 +669,17 @@</span><br><span>           }</span><br><span> </span><br><span>        case TS_EV_PDCH_ACT_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">-                /* Late PDCH activation ACK is not a crime.</span><br><span style="color: hsl(0, 100%, 40%);">-              * Just go into the PDCH mode as normal. */</span><br><span style="color: hsl(0, 100%, 40%);">-             osmo_fsm_inst_state_chg(fi, TS_ST_PDCH, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        case TS_EV_PDCH_ACT_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+             /* Late PDCH activation ACK/NACK is not a crime.</span><br><span style="color: hsl(120, 100%, 40%);">+               * Just process them as normal. */</span><br><span style="color: hsl(120, 100%, 40%);">+            ts_fsm_wait_pdch_act(fi, event, data);</span><br><span style="color: hsl(120, 100%, 40%);">+                return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     case TS_EV_PDCH_DEACT_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+    case TS_EV_PDCH_DEACT_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Late PDCH deactivation ACK/NACK is also not a crime.</span><br><span style="color: hsl(120, 100%, 40%);">+                * Just process them as normal. */</span><br><span style="color: hsl(120, 100%, 40%);">+            ts_fsm_wait_pdch_deact(fi, event, data);</span><br><span>             return;</span><br><span> </span><br><span>  default:</span><br><span>@@ -827,8 +835,13 @@</span><br><span>                      | S(TS_EV_LCHAN_REQUESTED)</span><br><span>                   | S(TS_EV_LCHAN_UNUSED)</span><br><span>                      | S(TS_EV_PDCH_ACT_ACK)</span><br><span style="color: hsl(120, 100%, 40%);">+                       | S(TS_EV_PDCH_ACT_NACK)</span><br><span style="color: hsl(120, 100%, 40%);">+                      | S(TS_EV_PDCH_DEACT_ACK)</span><br><span style="color: hsl(120, 100%, 40%);">+                     | S(TS_EV_PDCH_DEACT_NACK)</span><br><span>                   ,</span><br><span>            .out_state_mask = 0</span><br><span style="color: hsl(120, 100%, 40%);">+                   | S(TS_ST_IN_USE)</span><br><span style="color: hsl(120, 100%, 40%);">+                     | S(TS_ST_UNUSED)</span><br><span>                    | S(TS_ST_NOT_INITIALIZED)</span><br><span>                   | S(TS_ST_PDCH)</span><br><span>                      ,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18339">change 18339</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18339"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic87c325a73690ede1b81b4d33bac65a1a4beea2d </div>
<div style="display:none"> Gerrit-Change-Number: 18339 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>