<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/18343">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ran_msg_iu.c: Avoid redefining osmo-iuh global variables<br><br>From ASAn on gcc 10.1.0:<br>+=================================================================<br>+==269368==ERROR: AddressSanitizer: odr-violation (0x559114a5b880):<br>+  [1] size=4 'asn1_xer_print' /git/osmo-msc/src/libmsc/ran_msg_iu.c:50:5<br>+  [2] size=4 'asn1_xer_print' /git/osmo-iuh/src/iu_client.c:85:5<br>+These globals were registered at these points:<br>+  [1]:<br>+    #0 0x7f6208d3869a in __asan_register_globals /build/gcc/src/gcc/libsanitizer/asan/asan_globals.cpp:341<br>+    #1 0x55911456d221 in _sub_I_00099_1 (/build/new/tmpdir/osmo-msc/tests/msc_vlr/msc_vlr_test_hlr_timeout+0x48d221)<br>+    #2 0x5591145e8e9c in __libc_csu_init (/build/new/tmpdir/osmo-msc/tests/msc_vlr/msc_vlr_test_hlr_timeout+0x508e9c)<br>+<br>+  [2]:<br>+    #0 0x7f6208d3869a in __asan_register_globals /build/gcc/src/gcc/libsanitizer/asan/asan_globals.cpp:341<br>+    #1 0x7f6207d8db91 in _sub_I_00099_1 (/build/new/out/lib/libosmo-ranap.so.3+0x47db91)<br>+    #2 0x7f62096eb0f1 in call_init.part.0 (/lib64/ld-linux-x86-64.so.2+0x110f1)<br>+<br>+==269368==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0<br>+SUMMARY: AddressSanitizer: odr-violation: global 'asn1_xer_print' at /git/osmo-msc/src/libmsc/ran_msg_iu.c:50:5<br>+==269368==ABORTING<br><br>Related: OS#4556<br>Change-Id: I702e9748eaaf2279c3764ba67f80f00ae9f2526f<br>---<br>M src/libmsc/ran_msg_iu.c<br>1 file changed, 0 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c</span><br><span>index e056de4..b17aef8 100644</span><br><span>--- a/src/libmsc/ran_msg_iu.c</span><br><span>+++ b/src/libmsc/ran_msg_iu.c</span><br><span>@@ -39,16 +39,6 @@</span><br><span> #include <osmocom/msc/ran_msg_iu.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Implement the extern talloc_asn1_ctx from libasn1c as talloc ctx for ASN.1 message composition */</span><br><span style="color: hsl(0, 100%, 40%);">-void *talloc_asn1_ctx = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Implement the extern asn_debug from libasn1c to indicate whether to print asn.1 debug messages. */</span><br><span style="color: hsl(0, 100%, 40%);">-int asn_debug = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Implement the extern asn1_xer_print to indicate whether the ASN.1 binary code decoded and encoded during Iu</span><br><span style="color: hsl(0, 100%, 40%);">- * communication should be logged to stderr (see asn.1 generated code in osmo-iuh). */</span><br><span style="color: hsl(0, 100%, 40%);">-int asn1_xer_print = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define LOG_RAN_IU_DEC(RAN_DEC, level, fmt, args...) \</span><br><span>    LOG_RAN_DEC(RAN_DEC, DIUCS, level, "RANAP: " fmt, ## args)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/18343">change 18343</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/18343"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I702e9748eaaf2279c3764ba67f80f00ae9f2526f </div>
<div style="display:none"> Gerrit-Change-Number: 18343 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>