<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18318">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon: use buffer size macros for TRXC/TRXD messages<br><br>Change-Id: I6f2b8682c4691ed3da1bf804e302a7169f33e283<br>---<br>M src/host/trxcon/trx_if.c<br>M src/host/trxcon/trx_if.h<br>2 files changed, 7 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c</span><br><span>index 20c64ec..cb54c9e 100644</span><br><span>--- a/src/host/trxcon/trx_if.c</span><br><span>+++ b/src/host/trxcon/trx_if.c</span><br><span>@@ -446,7 +446,7 @@</span><br><span>     struct trx_instance *trx = ofd->data;</span><br><span>     struct trx_ctrl_msg *tcm;</span><br><span>    int resp, rsp_len;</span><br><span style="color: hsl(0, 100%, 40%);">-      char buf[1500], *p;</span><br><span style="color: hsl(120, 100%, 40%);">+   char buf[TRXC_BUF_SIZE], *p;</span><br><span>         ssize_t read_len;</span><br><span> </span><br><span>        read_len = read(ofd->fd, buf, sizeof(buf) - 1);</span><br><span>@@ -556,7 +556,7 @@</span><br><span> {</span><br><span>        struct trx_instance *trx = ofd->data;</span><br><span>     struct trx_meas_set meas;</span><br><span style="color: hsl(0, 100%, 40%);">-       uint8_t buf[256];</span><br><span style="color: hsl(120, 100%, 40%);">+     uint8_t buf[TRXD_BUF_SIZE];</span><br><span>  sbit_t bits[148];</span><br><span>    int8_t rssi, tn;</span><br><span>     int16_t toa256;</span><br><span>@@ -616,7 +616,7 @@</span><br><span> int trx_if_tx_burst(struct trx_instance *trx, uint8_t tn, uint32_t fn,</span><br><span>      uint8_t pwr, const ubit_t *bits)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   uint8_t buf[256];</span><br><span style="color: hsl(120, 100%, 40%);">+     uint8_t buf[TRXD_BUF_SIZE];</span><br><span> </span><br><span>      /**</span><br><span>   * We must be sure that we have clock,</span><br><span>diff --git a/src/host/trxcon/trx_if.h b/src/host/trxcon/trx_if.h</span><br><span>index a44600d..2fafa56 100644</span><br><span>--- a/src/host/trxcon/trx_if.h</span><br><span>+++ b/src/host/trxcon/trx_if.h</span><br><span>@@ -8,6 +8,9 @@</span><br><span> #include "scheduler.h"</span><br><span> #include "sched_trx.h"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define TRXC_BUF_SIZE        1024</span><br><span style="color: hsl(120, 100%, 40%);">+#define TRXD_BUF_SIZE     512</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Forward declaration to avoid mutual include */</span><br><span> struct l1ctl_link;</span><br><span> </span><br><span>@@ -49,7 +52,7 @@</span><br><span> </span><br><span> struct trx_ctrl_msg {</span><br><span>        struct llist_head list;</span><br><span style="color: hsl(0, 100%, 40%);">- char cmd[128];</span><br><span style="color: hsl(120, 100%, 40%);">+        char cmd[TRXC_BUF_SIZE];</span><br><span>     int retry_cnt;</span><br><span>       int critical;</span><br><span>        int cmd_len;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18318">change 18318</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18318"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f2b8682c4691ed3da1bf804e302a7169f33e283 </div>
<div style="display:none"> Gerrit-Change-Number: 18318 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>