<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18321">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce test TC_ul_intermediate_retrans<br><br>Test Verifies that if PCU doesn't get one of the intermediate UL data blocks in a UL<br>TBF, it will request retransmission through UL ACK/NACK (with missing block<br>in its bitmap) when CV=0 is received (and hence it knows no more data is to be<br>transferred).<br><br>This test fails as of current osmo-pcu master, and it's fixed there by<br>osmo-pcu.git Change-Id I9b4ef7b7277efa645bdb5becf2e9f6b32c99a9b1.<br><br>Change-Id: I204a470e47fcc5965de758ad9a275837e0c8034d<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 95 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index a87396c..43ed7c5 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1787,6 +1787,100 @@</span><br><span> f_TC_mt_ping_pong(ms_racap, exp_cs_mcs);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that if PCU doesn't get one of the intermediate UL data blocks in a UL</span><br><span style="color: hsl(120, 100%, 40%);">+ * TBF, it will request retransmission through UL ACK/NACK (with missing block</span><br><span style="color: hsl(120, 100%, 40%);">+ * in its bitmap) when CV=0 is received (and hence it knows no more data is to</span><br><span style="color: hsl(120, 100%, 40%);">+ * be transferred).</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_ul_intermediate_retrans() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var GsmRrMessage rr_imm_ass;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PacketUlAssign ul_tbf_ass;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) RlcmacUlBlock ul_data;</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean ok;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t sched_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 tlli := '00000001'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint14_t bsn := 5;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_BSSGP bssgp_pdu;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring total_payload;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring payload;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring lost_payload;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer padding_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint5_t tfi;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign('FFFFFFFF'O, tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish an Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ ok := f_establish_tbf(rr_imm_ass);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not ok) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Failed to establish TBF");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure we've got an Uplink TBF assignment */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_imm_ass_verify_ul_tbf_ass(rr_imm_ass, ul_tbf_ass);</span><br><span style="color: hsl(120, 100%, 40%);">+ tfi := ul_tbf_ass.dynamic.tfi_assignment;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span style="color: hsl(120, 100%, 40%);">+ contention resoultion) and make sure it is ACKED fine. */</span><br><span style="color: hsl(120, 100%, 40%);">+ payload := f_rnd_octstring(16); /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA_TLLI(</span><br><span style="color: hsl(120, 100%, 40%);">+ tfi := tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ cv := 15, /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */</span><br><span style="color: hsl(120, 100%, 40%);">+ bsn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ blocks := { valueof(t_RLCMAC_LLCBLOCK(payload)) },</span><br><span style="color: hsl(120, 100%, 40%);">+ tlli := tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ul_data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ts_RLCMAC_CTRL_ACK(tlli), 0, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send 2 packets, skip 1 (inc bsn) and send another one */</span><br><span style="color: hsl(120, 100%, 40%);">+ payload := f_rnd_octstring(20); /* 20 bytes fills the CS-1 llc block */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA(tfi := tfi, cv := 15, bsn := 1, blocks := {t_RLCMAC_LLCBLOCK(payload)});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ul_data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := total_payload & payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ payload := f_rnd_octstring(20); /* 20 bytes fills the CS-1 llc block */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA(tfi := tfi, cv := 15, bsn := 2, blocks := {t_RLCMAC_LLCBLOCK(payload)});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ul_data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := total_payload & payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ lost_payload := f_rnd_octstring(20); /* LOST PAYLOAD bsn=3, will be retransmitted, next bsn is increased +2 */</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := total_payload & lost_payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ payload := f_rnd_octstring(20); /* 20 bytes fills the CS-1 llc block */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA(tfi := tfi, cv := 15, bsn := 4, blocks := {t_RLCMAC_LLCBLOCK(payload)});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ul_data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := total_payload & payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send enough blocks to finish the transmission (since we were sending BSN=15, send BS_CV_MAX packets) */</span><br><span style="color: hsl(120, 100%, 40%);">+ total_payload := total_payload & f_tx_rlcmac_ul_n_blocks(ul_tbf_ass.dynamic.tfi_assignment, bsn, g_bs_cv_max);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* On CV=0, we'll receive a UL ACK asking about missing block */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: check ack ack bitmap (URBB) */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_data := t_RLCMAC_UL_DATA(tfi := tfi, cv := 15, bsn := 3, blocks := {t_RLCMAC_LLCBLOCK(lost_payload)});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ul_data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now final ack is recieved */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tx_rlcmac_ul_block(ts_RLCMAC_CTRL_ACK(tlli), 0, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* receive one message on BSSGP with all aggregated data in payload: */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(tlli, mp_gb_cfg.cell_id, total_payload));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Verify that if PCU doesn't get an ACK for first DL block after IMM ASS, it</span><br><span> * will retry by retransmitting both the IMM ASS + DL block after poll (ack)</span><br><span> * timeout occurs (specified by sent RRBP on DL block). */</span><br><span>@@ -2252,6 +2346,7 @@</span><br><span> execute( TC_force_two_phase_access() );</span><br><span> execute( TC_mt_ping_pong() );</span><br><span> execute( TC_mt_ping_pong_with_dl_racap() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute (TC_ul_intermediate_retrans() );</span><br><span> execute( TC_imm_ass_dl_block_retrans() );</span><br><span> execute( TC_dl_flow_more_blocks() );</span><br><span> execute( TC_paging_cs_from_bts() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18321">change 18321</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18321"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I204a470e47fcc5965de758ad9a275837e0c8034d </div>
<div style="display:none"> Gerrit-Change-Number: 18321 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>