<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18340">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_patch: Don't even parse MM INFO if TZ patching is not enabled.<br><br>Change-Id: Ief159111b8753db83861194c2a035a1f08eb77b0<br>---<br>M src/osmo-bsc/osmo_bsc_filter.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/18340/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_filter.c b/src/osmo-bsc/osmo_bsc_filter.c</span><br><span>index 3b72aee..b4985f2 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_filter.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_filter.c</span><br><span>@@ -49,6 +49,11 @@</span><br><span>     uint8_t tzbsd = 0;</span><br><span>   uint8_t dst = 0;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  /* Is TZ patching enabled? */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_tz *tz = &conn->network->tz;</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!tz->override)</span><br><span style="color: hsl(120, 100%, 40%);">+         return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, data, length, 0, 0);</span><br><span>        if (parse_res <= 0 && parse_res != -3)</span><br><span>            /* FIXME: -3 means unknown IE error, so this accepts messages</span><br><span>@@ -56,11 +61,6 @@</span><br><span>            * IE and the message is broken or parsed incompletely. */</span><br><span>           return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Is TZ patching enabled? */</span><br><span style="color: hsl(0, 100%, 40%);">-   struct gsm_tz *tz = &conn->network->tz;</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!tz->override)</span><br><span style="color: hsl(0, 100%, 40%);">-           return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Convert tz.hr and tz.mn to units */</span><br><span>       if (tz->hr < 0) {</span><br><span>              tzunits = -tz->hr*4;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18340">change 18340</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18340"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ief159111b8753db83861194c2a035a1f08eb77b0 </div>
<div style="display:none"> Gerrit-Change-Number: 18340 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>