<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18330">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bssmap: Ignore repeated BSSMAP RESET ACK messages.<br><br>We're sending multiple RESET messages to establish a conection with<br>an MSC and MSC can (and often will) respond with multiple RESET ACK<br>messages. We should not treat this as an ERROR as it used to be<br>in the original code.<br><br>Change-Id: I109d638d5167e24f0357e3541415b9e7269aa5d1<br>---<br>M src/osmo-bsc/a_reset.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c</span><br><span>index f990e63..713be86 100644</span><br><span>--- a/src/osmo-bsc/a_reset.c</span><br><span>+++ b/src/osmo-bsc/a_reset.c</span><br><span>@@ -103,6 +103,9 @@</span><br><span>        case EV_N_CONNECT:</span><br><span>           reset_ctx->conn_loss_counter = 0;</span><br><span>                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case EV_RESET_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGPFSML(fi, LOGL_INFO, "Received a duplicated BSSMAP RESET ACK, ignoring\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span>@@ -140,7 +143,7 @@</span><br><span>                  .onenter = fsm_disc_onenter_cb,</span><br><span>                      },</span><br><span>      [ST_CONN] = {</span><br><span style="color: hsl(0, 100%, 40%);">-                .in_event_mask = (1 << EV_N_DISCONNECT) | (1 << EV_N_CONNECT),</span><br><span style="color: hsl(120, 100%, 40%);">+                    .in_event_mask = (1 << EV_N_DISCONNECT) | (1 << EV_N_CONNECT) | (1 << EV_RESET_ACK),</span><br><span>               .out_state_mask = (1 << ST_DISC) | (1 << ST_CONN),</span><br><span>               .name = "CONN",</span><br><span>                    .action = fsm_conn_cb,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18330">change 18330</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18330"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I109d638d5167e24f0357e3541415b9e7269aa5d1 </div>
<div style="display:none"> Gerrit-Change-Number: 18330 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>