<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Add a BTS/BSC counter PAGING_NON_ACTIVE.<br><br>Otherwise we're missing an important part of the callflow and<br>the counters of responded/expired paging requests don't add up to<br>attempted paging number.<br><br>Change-Id: I1755be40d29980b75353cb4b8087d1ce0d92854a<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/gsm_08_08.c<br>2 files changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/18332/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index aeeb58d..4421c7c 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1412,6 +1412,7 @@</span><br><span>      BTS_CTR_PAGING_ALREADY,</span><br><span>      BTS_CTR_PAGING_RESPONDED,</span><br><span>    BTS_CTR_PAGING_EXPIRED,</span><br><span style="color: hsl(120, 100%, 40%);">+       BTS_CTR_PAGING_NON_ACTIVE,</span><br><span>   BTS_CTR_CHAN_ACT_TOTAL,</span><br><span>      BTS_CTR_CHAN_ACT_NACK,</span><br><span>       BTS_CTR_RSL_UNKNOWN,</span><br><span>@@ -1458,6 +1459,7 @@</span><br><span>         [BTS_CTR_PAGING_ALREADY] =              {"paging:already", "Paging attempts ignored as subscriber was already being paged."},</span><br><span>    [BTS_CTR_PAGING_RESPONDED] =            {"paging:responded", "Paging attempts with successful paging response."},</span><br><span>        [BTS_CTR_PAGING_EXPIRED] =              {"paging:expired", "Paging Request expired because of timeout T3113."},</span><br><span style="color: hsl(120, 100%, 40%);">+   [BTS_CTR_PAGING_NON_ACTIVE] =   {"paging:expired", "Non active subscriber responded to paging."},</span><br><span>        [BTS_CTR_CHAN_ACT_TOTAL] =              {"chan_act:total", "Total number of Channel Activations."},</span><br><span>      [BTS_CTR_CHAN_ACT_NACK] =               {"chan_act:nack", "Number of Channel Activations that the BTS NACKed"},</span><br><span>  [BTS_CTR_RSL_UNKNOWN] =                 {"rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS"},</span><br><span>@@ -1554,6 +1556,7 @@</span><br><span>         BSC_CTR_PAGING_ATTEMPTED,</span><br><span>    BSC_CTR_PAGING_DETACHED,</span><br><span>     BSC_CTR_PAGING_RESPONDED,</span><br><span style="color: hsl(120, 100%, 40%);">+     BSC_CTR_PAGING_NON_ACTIVE,</span><br><span>   BSC_CTR_UNKNOWN_UNIT_ID,</span><br><span> };</span><br><span> </span><br><span>@@ -1598,6 +1601,7 @@</span><br><span>   [BSC_CTR_PAGING_ATTEMPTED] =            {"paging:attempted", "Paging attempts for a subscriber."},</span><br><span>       [BSC_CTR_PAGING_DETACHED] =             {"paging:detached", "Paging request send failures because no responsible BTS was found."},</span><br><span>       [BSC_CTR_PAGING_RESPONDED] =            {"paging:responded", "Paging attempts with successful response."},</span><br><span style="color: hsl(120, 100%, 40%);">+        [BSC_CTR_PAGING_NON_ACTIVE] =           {"paging:expired", "Paging response for non active subscriber."},</span><br><span> </span><br><span>    [BSC_CTR_UNKNOWN_UNIT_ID] =             {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID."},</span><br><span> };</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 4f9c69e..2b06623 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -388,6 +388,8 @@</span><br><span> </span><br><span>      if (!subscr) {</span><br><span>               LOGP(DMSC, LOGL_ERROR, "Non active subscriber got paged.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               rate_ctr_inc(&_bts->bts_ctrs->ctr[BTS_CTR_PAGING_NON_ACTIVE]);</span><br><span style="color: hsl(120, 100%, 40%);">+              rate_ctr_inc(&_bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_NON_ACTIVE]);</span><br><span>                 return -1;</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332">change 18332</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18332"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1755be40d29980b75353cb4b8087d1ce0d92854a </div>
<div style="display:none"> Gerrit-Change-Number: 18332 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>