<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18320">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MGCP_Test: do not use leading zeros in endpoint identifiers<br><br>The endpoint number of a virtual endpoint must not use leading zeros<br>but, but the testcase MGCP_Test.TC_crcx_dlcx_30ep does. Lets not do this<br>as it violates the spec. See also: RFC 3435, section E.3.<br><br>Change-Id: I99d2fa76cb60d0d671c9413f3dbd711ec68aeb77<br>Related: OS#2659<br>---<br>M mgw/MGCP_Test.ttcn<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn</span><br><span>index 77eed4b..0de5308 100644</span><br><span>--- a/mgw/MGCP_Test.ttcn</span><br><span>+++ b/mgw/MGCP_Test.ttcn</span><br><span>@@ -1420,7 +1420,11 @@</span><br><span>                 f_init();</span><br><span> </span><br><span>                for (ep_nr := 1; ep_nr < 30; ep_nr := ep_nr+1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     ep := c_mgw_ep_rtpbridge & hex2str(int2hex(ep_nr, 2)) & "@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+                     if(ep_nr > 15) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           ep := c_mgw_ep_rtpbridge & hex2str(int2hex(ep_nr, 2)) & "@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+                     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                              ep := c_mgw_ep_rtpbridge & hex2str(int2hex(ep_nr, 1)) & "@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+                     }</span><br><span>                    call_id := int2hex(ep_nr, 2) & '1234'H;</span><br><span>                  f_crcx_and_dlcx_ep_callid_connid(ep, call_id);</span><br><span>               }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18320">change 18320</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18320"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I99d2fa76cb60d0d671c9413f3dbd711ec68aeb77 </div>
<div style="display:none"> Gerrit-Change-Number: 18320 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>