<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18325">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/rand_burst_gen.py: use list comprehension<br><br>See previous commit, TL;DR this approach is significantly faster.<br><br>Change-Id: I5dc0dda89443d2763bfae50cc402724935cc91b3<br>---<br>M src/target/trx_toolkit/rand_burst_gen.py<br>1 file changed, 5 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/25/18325/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>index be4b696..a56467f 100644</span><br><span>--- a/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>+++ b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>@@ -57,8 +57,7 @@</span><br><span>                buf += [0] * 3</span><br><span> </span><br><span>           # Random data 1 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             for i in range(0, 57):</span><br><span style="color: hsl(0, 100%, 40%);">-                  buf.append(random.randint(0, 1))</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for i in range(57)]</span><br><span> </span><br><span>                 # Steal flag 1 / 2</span><br><span>           buf.append(random.randint(0, 1))</span><br><span>@@ -72,8 +71,7 @@</span><br><span>                 buf.append(random.randint(0, 1))</span><br><span> </span><br><span>                 # Random data 2 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             for i in range(0, 57):</span><br><span style="color: hsl(0, 100%, 40%);">-                  buf.append(random.randint(0, 1))</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for i in range(57)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span>@@ -92,8 +90,7 @@</span><br><span>           buf += [0] * 3</span><br><span> </span><br><span>           # Random data 1 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             for i in range(0, 39):</span><br><span style="color: hsl(0, 100%, 40%);">-                  buf.append(random.randint(0, 1))</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for i in range(39)]</span><br><span> </span><br><span>                 # Training sequence</span><br><span>          if tsc is None:</span><br><span>@@ -101,8 +98,7 @@</span><br><span>                 buf += tsc.seq</span><br><span> </span><br><span>           # Random data 2 / 2</span><br><span style="color: hsl(0, 100%, 40%);">-             for i in range(0, 39):</span><br><span style="color: hsl(0, 100%, 40%);">-                  buf.append(random.randint(0, 1))</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for i in range(39)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span>@@ -126,8 +122,7 @@</span><br><span>                 buf += tsc.seq</span><br><span> </span><br><span>           # Random data</span><br><span style="color: hsl(0, 100%, 40%);">-           for i in range(0, 36):</span><br><span style="color: hsl(0, 100%, 40%);">-                  buf.append(random.randint(0, 1))</span><br><span style="color: hsl(120, 100%, 40%);">+              buf += [random.randint(0, 1) for i in range(36)]</span><br><span> </span><br><span>                 # Tailing bits</span><br><span>               buf += [0] * 3</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18325">change 18325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5dc0dda89443d2763bfae50cc402724935cc91b3 </div>
<div style="display:none"> Gerrit-Change-Number: 18325 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>