<p style="white-space: pre-wrap; word-wrap: break-word;">This change is ready for review.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1//COMMIT_MSG@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace"> b) The L1 maintains several Transceivers (two or more), so each</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It can still probably work with 1, but of course the same 1 is always selected :P</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It does not make any sense (basically no hopping), but of course we can allow it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1//COMMIT_MSG@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> CMD SETFH <HSN> <MAIO> <RXF1> <TXF1></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">wouldn't it make more sense to submit ARFCNs here instead of Rx+Tx frequency pairs?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It would if there was a clear distinction between transceivers in fake_trx.py, i.e. which one is an MS and which is a BTS. Right now every transceiver is an abstract entity that emits and receives bursts. So when you convert an ARFCN to a pair of Downlink/Uplink frequencies, you don't know whether it maps as Rx/Tx or Tx/Rx for a given transceiver.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Of course, we could assume that this is an MS specific feature, and Downlink/Uplink always correspond to Rx/Tx, but what if some day we would need to implement _and test_ variant a) for the BTS side? Also, by sending frequency values in kHz (rather than ARFCNs) we can avoid inconsistency with the existing RXTUNE / TXTUNE commands.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1/src/target/trx_toolkit/fake_pm.py">File src/target/trx_toolkit/fake_pm.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1/src/target/trx_toolkit/fake_pm.py@76">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace"> continue</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">probably print something here saying it's missing.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not really needed. This measurement capability was implemented for BCCH scan (L1CTL_PM_REQ or so), which we don't use in our TTCN-3 test cases. And moreover, BCCH shall not use hopping, so not critical.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1/src/target/trx_toolkit/transceiver.py">File src/target/trx_toolkit/transceiver.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262/1/src/target/trx_toolkit/transceiver.py@192">Patch Set #1, Line 192:</a> <code style="font-family:monospace,monospace"> if self.fh is None:</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Are you sure these 2 conditions are correct?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes. In the case when frequency hopping is not in use, both Rx and Tx frequencies must be configured (not None). If either of both frequencies is not set (None), and frequency hopping is not in configured, then a Transceiver is not ready to be powered on.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262">change 18262</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18262"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I587e4f5da67c7b7f28e010ed46b24622c31a3fdd </div>
<div style="display:none"> Gerrit-Change-Number: 18262 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 May 2020 14:30:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>