<p>osmith would like laforge to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18266">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">virt_phy: tweak log levels<br><br>Related: SYS#4822<br>Change-Id: Ia7e368cda8e016a4141b21e5219697420a503124<br>---<br>M src/host/virt_phy/src/l1ctl_sap.c<br>M src/host/virt_phy/src/logging.c<br>M src/host/virt_phy/src/virt_prim_data.c<br>M src/host/virt_phy/src/virt_prim_pm.c<br>4 files changed, 11 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/18266/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c</span><br><span>index 0ff5412..bab6259 100644</span><br><span>--- a/src/host/virt_phy/src/l1ctl_sap.c</span><br><span>+++ b/src/host/virt_phy/src/l1ctl_sap.c</span><br><span>@@ -286,7 +286,7 @@</span><br><span> </span><br><span>       rsl_dec_chan_nr(ul->chan_nr, &rsl_chantype, &subslot, &timeslot);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    LOGPMS(DL1C, LOGL_INFO, ms, "Rx L1CTL_DM_EST_REQ (chan_nr=0x%02x, arfcn=%u, tn=%u, ss=%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGPMS(DL1C, LOGL_DEBUG, ms, "Rx L1CTL_DM_EST_REQ (chan_nr=0x%02x, arfcn=%u, tn=%u, ss=%u)\n",</span><br><span>             ul->chan_nr, ntohs(est_req->h0.band_arfcn), timeslot, subslot);</span><br><span> </span><br><span>    OSMO_ASSERT(est_req->h == 0); /* we don't do hopping */</span><br><span>diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c</span><br><span>index aa3b88a..75f0c9a 100644</span><br><span>--- a/src/host/virt_phy/src/logging.c</span><br><span>+++ b/src/host/virt_phy/src/logging.c</span><br><span>@@ -70,28 +70,28 @@</span><br><span>                .description = "Layer 1 Control",</span><br><span>          .color = "\033[1;31m",</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-           .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+               .loglevel = LOGL_INFO,</span><br><span>       },</span><br><span>   [DL1P] = {</span><br><span>           .name = "DL1P",</span><br><span>            .description = "Layer 1 Data",</span><br><span>             .color = "\033[1;31m",</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-           .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+               .loglevel = LOGL_INFO,</span><br><span>       },</span><br><span>   [DVIRPHY] = {</span><br><span>                .name = "DVIRPHY",</span><br><span>                 .description = "Virtual Layer 1 Interface",</span><br><span>                .color = "\033[1;31m",</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-           .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+               .loglevel = LOGL_INFO,</span><br><span>       },</span><br><span>   [DMAIN] = {</span><br><span>          .name = "DMAIN",</span><br><span>           .description = "Main Program / Data Structures",</span><br><span>           .color = "\033[1;32m",</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-           .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+               .loglevel = LOGL_INFO,</span><br><span>       },</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/host/virt_phy/src/virt_prim_data.c b/src/host/virt_phy/src/virt_prim_data.c</span><br><span>index 65368b8..656ff80 100644</span><br><span>--- a/src/host/virt_phy/src/virt_prim_data.c</span><br><span>+++ b/src/host/virt_phy/src/virt_prim_data.c</span><br><span>@@ -74,7 +74,7 @@</span><br><span>        rsl_dec_chan_nr(ul->chan_nr, &rsl_chantype, &subslot, &timeslot);</span><br><span>     msg->l2h = data_ind->data;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    LOGPMS(DL1P, LOGL_INFO, ms, "Rx L1CTL_DATA_REQ (chan_nr=0x%02x, link_id=0x%02x) %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+      LOGPMS(DL1P, LOGL_DEBUG, ms, "Rx L1CTL_DATA_REQ (chan_nr=0x%02x, link_id=0x%02x) %s\n",</span><br><span>            ul->chan_nr, ul->link_id, osmo_hexdump(msg->l2h, msgb_l2len(msg)));</span><br><span> </span><br><span>     virt_l1_sched_schedule(ms, msg, fn_sched, timeslot, &virt_l1_sched_handler_cb);</span><br><span>@@ -106,7 +106,7 @@</span><br><span> </span><br><span>        memcpy(l1di->data, msgb_data(msg), msgb_length(msg));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    LOGPMS(DL1P, LOGL_INFO, ms, "TX L1CTL_DATA_IND (link_id=0x%02x) %s\n", link_id,</span><br><span style="color: hsl(120, 100%, 40%);">+     LOGPMS(DL1P, LOGL_DEBUG, ms, "TX L1CTL_DATA_IND (link_id=0x%02x) %s\n", link_id,</span><br><span>            osmo_hexdump(msgb_data(msg), msgb_length(msg)));</span><br><span>    l1ctl_sap_tx_to_l23_inst(ms, l1ctl_msg);</span><br><span> }</span><br><span>@@ -124,6 +124,6 @@</span><br><span>  struct msgb * l1ctl_msg;</span><br><span>     l1ctl_msg = l1ctl_create_l2_msg(L1CTL_DATA_CONF, fn, snr, arfcn);</span><br><span>    /* send confirm to layer23 */</span><br><span style="color: hsl(0, 100%, 40%);">-   LOGPMS(DL1P, LOGL_INFO, ms, "Tx L1CTL_DATA_CONF\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        LOGPMS(DL1P, LOGL_DEBUG, ms, "Tx L1CTL_DATA_CONF\n");</span><br><span>      l1ctl_sap_tx_to_l23_inst(ms, l1ctl_msg);</span><br><span> }</span><br><span>diff --git a/src/host/virt_phy/src/virt_prim_pm.c b/src/host/virt_phy/src/virt_prim_pm.c</span><br><span>index 561f6ce..08d9b05 100644</span><br><span>--- a/src/host/virt_phy/src/virt_prim_pm.c</span><br><span>+++ b/src/host/virt_phy/src/virt_prim_pm.c</span><br><span>@@ -89,7 +89,7 @@</span><br><span>       l1s->pm.req.band_arfcn_from = ntohs(pm_req->range.band_arfcn_from);</span><br><span>    l1s->pm.req.band_arfcn_to = ntohs(pm_req->range.band_arfcn_to);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       LOGPMS(DL1C, LOGL_INFO, ms, "Rx L1CTL_PM_REQ TYPE=%u, FROM=%d, TO=%d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+    LOGPMS(DL1C, LOGL_DEBUG, ms, "Rx L1CTL_PM_REQ TYPE=%u, FROM=%d, TO=%d\n",</span><br><span>          pm_req->type, l1s->pm.req.band_arfcn_from, l1s->pm.req.band_arfcn_to);</span><br><span> </span><br><span>  /* generating the response will happen delayed in a timer, as otherwise</span><br><span>@@ -119,14 +119,14 @@</span><br><span>              }</span><br><span>            /* no more space to hold more pm info in msgb, flush to l23 */</span><br><span>               if (msgb_tailroom(resp_msg) < sizeof(*pm_conf)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    LOGPMS(DL1C, LOGL_INFO, ms, "Tx L1CTL_PM_CONF\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGPMS(DL1C, LOGL_DEBUG, ms, "Tx L1CTL_PM_CONF\n");</span><br><span>                        l1ctl_sap_tx_to_l23_inst(ms, resp_msg);</span><br><span>                      resp_msg = l1ctl_msgb_alloc(L1CTL_PM_CONF);</span><br><span>          }</span><br><span>    }</span><br><span>    /* transmit the remaining part of pm response to l23 */</span><br><span>      if (resp_msg) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGPMS(DL1C, LOGL_INFO, ms, "Tx L1CTL_PM_CONF\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPMS(DL1C, LOGL_DEBUG, ms, "Tx L1CTL_PM_CONF\n");</span><br><span>                l1ctl_sap_tx_to_l23_inst(ms, resp_msg);</span><br><span>      }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/18266">change 18266</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/18266"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia7e368cda8e016a4141b21e5219697420a503124 </div>
<div style="display:none"> Gerrit-Change-Number: 18266 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>