<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18247">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18247/5/src/gsm/i460_mux.c">File src/gsm/i460_mux.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/18247/5/src/gsm/i460_mux.c@208">Patch Set #5, Line 208:</a> <code style="font-family:monospace,monospace">static uint8_t mux_timeslot_provide_bits(struct osmo_i460_timeslot *ts)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">According to the specs, any bits that's not used by a subchannel should be set to 1.<br>This doesn't do that AFAICT.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18247">change 18247</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18247"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id522f06e73b77332b437b7a27e4966872da70eda </div>
<div style="display:none"> Gerrit-Change-Number: 18247 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 May 2020 11:05:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>