<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block<br><br>Downlink Control blocks like Packet Uplink Assignment (PACCH)<br>contain rrbp + rrbp_valid in mac headers<br><br>Change-Id: I0401b0b378c7770d06a15d14dac6436303b4ccab<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/18235/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index efb7d94..5ef53a9 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -708,9 +708,8 @@</span><br><span>            rrbp_valid := dl_block.data.mac_hdr.mac_hdr.rrbp_valid;</span><br><span>              rrbp := dl_block.data.mac_hdr.mac_hdr.rrbp;</span><br><span>  } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                /* Should not happen, but the caller may theoretically give us a CTRL block */</span><br><span style="color: hsl(0, 100%, 40%);">-          setverdict(fail, "DL block is neither GPRS nor EGPRS data block: ", dl_block);</span><br><span style="color: hsl(0, 100%, 40%);">-                f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+              rrbp_valid := dl_block.ctrl.mac_hdr.rrbp_valid;</span><br><span style="color: hsl(120, 100%, 40%);">+               rrbp := dl_block.ctrl.mac_hdr.rrbp;</span><br><span>  }</span><br><span> </span><br><span>        /* Make sure that the given block really needs to be ACKnowledged */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235">change 18235</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0401b0b378c7770d06a15d14dac6436303b4ccab </div>
<div style="display:none"> Gerrit-Change-Number: 18235 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>