<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18212">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: Fix encoding of the SAPI_N_REJECT BSSMAP message.<br><br>See TS 08.08 section 3.2.1.34 SAPI "n" REJECT:<br>1) DLCI is a TV element, not V.<br>2) Cause is a TLV element and we have a special function to encode it.<br><br>Change-Id: I033afe556c06427d06ac55c4f78854a45e41aae6<br>---<br>M src/gsm/gsm0808.c<br>M tests/gsm0808/gsm0808_test.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index f9f7b58..02288e6 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -447,8 +447,8 @@</span><br><span>          return NULL;</span><br><span> </span><br><span>     msgb_v_put(msg, BSS_MAP_MSG_SAPI_N_REJECT);</span><br><span style="color: hsl(0, 100%, 40%);">-     msgb_v_put(msg, link_id);</span><br><span style="color: hsl(0, 100%, 40%);">-       msgb_v_put(msg, GSM0808_CAUSE_BSS_NOT_EQUIPPED);</span><br><span style="color: hsl(120, 100%, 40%);">+      msgb_tv_put(msg, GSM0808_IE_DLCI, link_id);</span><br><span style="color: hsl(120, 100%, 40%);">+   gsm0808_enc_cause(msg, GSM0808_CAUSE_BSS_NOT_EQUIPPED);</span><br><span> </span><br><span>  msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg));</span><br><span> </span><br><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index 2389218..ec24914 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -370,7 +370,7 @@</span><br><span> </span><br><span> static void test_create_sapi_reject()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   static const uint8_t res[] = { 0x00, 0x03, 0x25, 0x03, 0x25 };</span><br><span style="color: hsl(120, 100%, 40%);">+        static const uint8_t res[] = { 0x00, 0x06, 0x25, 0x18, 0x03, 0x04, 0x01, 0x25 };</span><br><span>     struct msgb *msg;</span><br><span> </span><br><span>        printf("Testing creating SAPI Reject\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18212">change 18212</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18212"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I033afe556c06427d06ac55c4f78854a45e41aae6 </div>
<div style="display:none"> Gerrit-Change-Number: 18212 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>