<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17931">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0505_amr_dtx: add missing value strings<br><br>The value string array that explain the type of the AMR DTX / SID<br>frames is incomplete, lets add the missing strings.<br><br>Change-Id: If9e80b4bd8bdc31323c7c276155b2538e20a99be<br>Related: OS#2978<br>---<br>M src/coding/gsm0503_amr_dtx.c<br>M tests/dtx/dtx_gsm0503_test.ok<br>2 files changed, 7 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/coding/gsm0503_amr_dtx.c b/src/coding/gsm0503_amr_dtx.c</span><br><span>index 724cf09..7069b96 100644</span><br><span>--- a/src/coding/gsm0503_amr_dtx.c</span><br><span>+++ b/src/coding/gsm0503_amr_dtx.c</span><br><span>@@ -45,16 +45,18 @@</span><br><span> static const ubit_t codec_mode_4_sid[] = { 0, 0, 1, 0, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 1, 1 };</span><br><span> </span><br><span> const struct value_string gsm0503_amr_dtx_frame_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { AMR_OTHER,            "AMR_OTHER (audio)" },</span><br><span>     { AFS_SID_FIRST,        "AFS_SID_FIRST" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { AFS_SID_UPDATE,       "AFS_SID_UPDATE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { AFS_SID_UPDATE,       "AFS_SID_UPDATE (marker)" },</span><br><span style="color: hsl(120, 100%, 40%);">+        { AFS_SID_UPDATE_CN,    "AFS_SID_UPDATE_CN (audio)" },</span><br><span>     { AFS_ONSET,            "AFS_ONSET" },</span><br><span style="color: hsl(0, 100%, 40%);">-        { AHS_SID_UPDATE,       "AHS_SID_UPDATE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { AHS_SID_UPDATE,       "AHS_SID_UPDATE (marker)" },</span><br><span style="color: hsl(120, 100%, 40%);">+        { AHS_SID_UPDATE_CN,    "AHS_SID_UPDATE_CN (audio)" },</span><br><span>     { AHS_SID_FIRST_P1,     "AHS_SID_FIRST_P1" },</span><br><span>      { AHS_SID_FIRST_P2,     "AHS_SID_FIRST_P2" },</span><br><span>      { AHS_ONSET,            "AHS_ONSET" },</span><br><span>     { AHS_SID_FIRST_INH,    "AHS_SID_FIRST_INH" },</span><br><span>     { AHS_SID_UPDATE_INH,   "AHS_SID_UPDATE_INH" },</span><br><span style="color: hsl(0, 100%, 40%);">-       { AMR_OTHER,            "NON DTX FRAME (OTHER)" },</span><br><span>         { 0, NULL }</span><br><span> };</span><br><span> </span><br><span>diff --git a/tests/dtx/dtx_gsm0503_test.ok b/tests/dtx/dtx_gsm0503_test.ok</span><br><span>index a95a18b..77a4936 100644</span><br><span>--- a/tests/dtx/dtx_gsm0503_test.ok</span><br><span>+++ b/tests/dtx/dtx_gsm0503_test.ok</span><br><span>@@ -1,9 +1,9 @@</span><br><span> FR AMR DTX FRAMES:</span><br><span>  ==> AFS_SID_FIRST, n_errors=0, n_bits_total=212</span><br><span style="color: hsl(0, 100%, 40%);">- ==> AFS_SID_UPDATE, n_errors=0, n_bits_total=212</span><br><span style="color: hsl(120, 100%, 40%);">+ ==> AFS_SID_UPDATE (marker), n_errors=0, n_bits_total=212</span><br><span>  ==> AFS_ONSET, n_errors=0, n_bits_total=228</span><br><span> HR AMR DTX FRAMES:</span><br><span style="color: hsl(0, 100%, 40%);">- ==> AHS_SID_UPDATE, n_errors=0, n_bits_total=212</span><br><span style="color: hsl(120, 100%, 40%);">+ ==> AHS_SID_UPDATE (marker), n_errors=0, n_bits_total=212</span><br><span>  ==> AHS_SID_FIRST_P1, n_errors=0, n_bits_total=212</span><br><span>  ==> AHS_SID_FIRST_P2, n_errors=0, n_bits_total=114</span><br><span>  ==> AHS_ONSET, n_errors=0, n_bits_total=114</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17931">change 17931</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17931"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If9e80b4bd8bdc31323c7c276155b2538e20a99be </div>
<div style="display:none"> Gerrit-Change-Number: 17931 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>