<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18224">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Drop unneeded arg 'ta' in tbf_alloc_ul()<br><br>The function is simply setting the ta on the ms, so simply make sure ta<br>is set on callers before passing the ms object.<br><br>Change-Id: Iebb9c57f458690e045ddc45c800209ad8cf621e0<br>---<br>M src/pdch.cpp<br>M src/tbf.cpp<br>M src/tbf.h<br>M tests/tbf/TbfTest.err<br>4 files changed, 16 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/24/18224/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 048577d..88d5d31 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -118,7 +118,7 @@</span><br><span> bts->channel_request_description();</span><br><span> </span><br><span> /* This call will register the new TBF with the MS on success */</span><br><span style="color: hsl(0, 100%, 40%);">- gprs_rlcmac_ul_tbf *ul_tbf = tbf_alloc_ul(bts_data, tbf->ms(), tbf->trx->trx_no, tbf->tlli(), tbf->ta());</span><br><span style="color: hsl(120, 100%, 40%);">+ gprs_rlcmac_ul_tbf *ul_tbf = tbf_alloc_ul(bts_data, tbf->ms(), tbf->trx->trx_no, tbf->tlli());</span><br><span> </span><br><span> /* schedule uplink assignment or reject */</span><br><span> if (ul_tbf) {</span><br><span>@@ -551,7 +551,6 @@</span><br><span> struct gprs_rlcmac_ul_tbf *ul_tbf;</span><br><span> struct gprs_rlcmac_dl_tbf *dl_tbf;</span><br><span> uint32_t tlli = request->ID.u.TLLI;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t ta = GSM48_TA_INVALID;</span><br><span> bool found = true;</span><br><span> </span><br><span> GprsMs *ms = bts()->ms_by_tlli(tlli);</span><br><span>@@ -566,7 +565,6 @@</span><br><span> if (found) {</span><br><span> ul_tbf = ms->ul_tbf();</span><br><span> dl_tbf = ms->dl_tbf();</span><br><span style="color: hsl(0, 100%, 40%);">- ta = ms->ta();</span><br><span> /* We got a RACH so the MS was in packet idle mode and thus</span><br><span> * didn't have any active TBFs */</span><br><span> if (ul_tbf) {</span><br><span>@@ -593,7 +591,7 @@</span><br><span> "block, but there is no resource request "</span><br><span> "scheduled!\n");</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- ta = sba->ta;</span><br><span style="color: hsl(120, 100%, 40%);">+ ms->set_ta(sba->ta);</span><br><span> bts()->sba()->free_sba(sba);</span><br><span> }</span><br><span> if (request->Exist_MS_Radio_Access_capability2) {</span><br><span>@@ -613,7 +611,7 @@</span><br><span> "MS supports EGPRS multislot class %d.\n",</span><br><span> ms->egprs_ms_class());</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ul_tbf = tbf_alloc_ul(bts_data(), ms, trx_no(), tlli, ta);</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf = tbf_alloc_ul(bts_data(), ms, trx_no(), tlli);</span><br><span> if (!ul_tbf) {</span><br><span> handle_tbf_reject(bts_data(), ms, tlli,</span><br><span> trx_no(), ts_no);</span><br><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 56fdcd1..2693223 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -416,7 +416,7 @@</span><br><span> }</span><br><span> </span><br><span> gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx,</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t tlli, uint8_t ta)</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t tlli)</span><br><span> {</span><br><span> struct gprs_rlcmac_ul_tbf *tbf;</span><br><span> </span><br><span>@@ -435,8 +435,6 @@</span><br><span> tbf->update_ms(tlli, GPRS_RLCMAC_UL_TBF);</span><br><span> OSMO_ASSERT(tbf->ms());</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- tbf->ms()->set_ta(ta);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> return tbf;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/tbf.h b/src/tbf.h</span><br><span>index 5ebd2e8..2b4cf6d 100644</span><br><span>--- a/src/tbf.h</span><br><span>+++ b/src/tbf.h</span><br><span>@@ -347,7 +347,7 @@</span><br><span> </span><br><span> </span><br><span> struct gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, GprsMs *ms,</span><br><span style="color: hsl(0, 100%, 40%);">- int8_t use_trx, uint32_t tlli, uint8_t ta);</span><br><span style="color: hsl(120, 100%, 40%);">+ int8_t use_trx, uint32_t tlli);</span><br><span> </span><br><span> struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx, bool single_slot);</span><br><span> </span><br><span>diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err</span><br><span>index 6019def..ca16149 100644</span><br><span>--- a/tests/tbf/TbfTest.err</span><br><span>+++ b/tests/tbf/TbfTest.err</span><br><span>@@ -1526,6 +1526,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -1545,7 +1546,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH)</span><br><span>@@ -1608,6 +1608,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -1627,7 +1628,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH)</span><br><span>@@ -1738,6 +1738,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -1757,7 +1758,6 @@</span><br><span> TBF(TFI=1 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=1 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf5667788, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf5667788, TA 220 -> 7</span><br><span> TBF(TFI=1 TLLI=0xf5667788 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=1 TLLI=0xf5667788 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> Received RTS for PDCH: TRX=0 TS=7 FN=2654335 block_nr=11 scheduling USF=0 for required uplink resource of UL TFI=0</span><br><span>@@ -1805,6 +1805,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -1824,7 +1825,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink CS level: CS-1 -> CS-2</span><br><span>@@ -1977,6 +1977,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -1996,7 +1997,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink CS level: CS-1 -> CS-2</span><br><span>@@ -2128,6 +2128,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> ********** UL-TBF starts here **********</span><br><span> Allocating UL TBF: MS_CLASS=1/0</span><br><span>@@ -2147,7 +2148,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink CS level: CS-1 -> CS-2</span><br><span>@@ -3151,6 +3151,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> Modifying MS object, TLLI = 0x00000000, EGPRS MS class 0 -> 1</span><br><span> MS supports EGPRS multislot class 1.</span><br><span>@@ -3175,7 +3176,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL EGPRS) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN EGPRS) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> max_cs_ul cannot be derived (current UL CS: UNKNOWN)</span><br><span>@@ -3243,6 +3243,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> Modifying MS object, TLLI = 0x00000000, EGPRS MS class 0 -> 1</span><br><span> MS supports EGPRS multislot class 1.</span><br><span>@@ -3267,7 +3268,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL EGPRS) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN EGPRS) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> max_cs_ul cannot be derived (current UL CS: UNKNOWN)</span><br><span>@@ -5882,6 +5882,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> Modifying MS object, TLLI = 0x00000000, EGPRS MS class 0 -> 1</span><br><span> MS supports EGPRS multislot class 1.</span><br><span>@@ -5906,7 +5907,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL EGPRS) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN EGPRS) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> max_cs_ul cannot be derived (current UL CS: UNKNOWN)</span><br><span>@@ -6047,6 +6047,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> Modifying MS object, TLLI = 0x00000000, EGPRS MS class 0 -> 1</span><br><span> MS supports EGPRS multislot class 1.</span><br><span>@@ -6071,7 +6072,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL EGPRS) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN EGPRS) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> max_cs_ul cannot be derived (current UL CS: UNKNOWN)</span><br><span>@@ -6392,6 +6392,7 @@</span><br><span> ------------------------- RX : Uplink Control Block -------------------------</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span> MS requests UL TBF in packet resource request of single block, so we provide one:</span><br><span style="color: hsl(120, 100%, 40%);">+Modifying MS object, TLLI = 0x00000000, TA 220 -> 7</span><br><span> Modifying MS object, TLLI = 0x00000000, MS class 0 -> 1</span><br><span> Modifying MS object, TLLI = 0x00000000, EGPRS MS class 0 -> 1</span><br><span> MS supports EGPRS multislot class 1.</span><br><span>@@ -6416,7 +6417,6 @@</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL EGPRS) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=ASSIGN EGPRS) starting timer T3169 [allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0</span><br><span> Modifying MS object, UL TLLI: 0x00000000 -> 0xf1223344, not yet confirmed</span><br><span style="color: hsl(0, 100%, 40%);">-Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete.</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) changes UL ASS state from GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS</span><br><span> max_cs_ul cannot be derived (current UL CS: UNKNOWN)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18224">change 18224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/18224"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iebb9c57f458690e045ddc45c800209ad8cf621e0 </div>
<div style="display:none"> Gerrit-Change-Number: 18224 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>