<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18193">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: make ho_config_tests more robust against timing<br><br>In f_probe_for_handover disable the RSL emulation before the vty handover<br>command.  Otherwise, osmo-bsc may be too fast to issue the handoverCommand, so<br>that RSLem still handles it and says: "RSL for unknown Dchan".<br><br>(f_probe_for_handover() receives the handoverCommand directly, just to detect<br>whether a handover would be initiated, and then quickly aborts the handover<br>procedure.)<br><br>Related: OS#4264<br>Change-Id: I7f73ef8cbdf46e31a46c9e1b7ad0fa2bd41c0a12<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 353ab16..38a961b 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -3668,6 +3668,11 @@</span><br><span>                                boolean is_inter_bsc_handover := false)</span><br><span> runs on MSC_ConnHdlr</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+    /* We're going to thwart any and all handover attempts, just be ready to handle (and ignore) handover target</span><br><span style="color: hsl(120, 100%, 40%);">+       * lchans to be established on bts 1 or bts 2. */</span><br><span style="color: hsl(120, 100%, 40%);">+     f_rslem_suspend(RSL1_PROC);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_rslem_suspend(RSL2_PROC);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        var RSL_Message rsl;</span><br><span> </span><br><span>     var charstring log_msg := " (expecting handover)"</span><br><span>@@ -3677,11 +3682,6 @@</span><br><span>         log("f_probe_for_handover starting: " & log_label & ": " & log_descr & log_msg);</span><br><span>         f_vty_transceive(BSCVTY, handover_vty_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* We're going to thwart any and all handover attempts, just be ready to handle (and ignore) handover target</span><br><span style="color: hsl(0, 100%, 40%);">-         * lchans to be established on bts 1 or bts 2. */</span><br><span style="color: hsl(0, 100%, 40%);">-       f_rslem_suspend(RSL1_PROC);</span><br><span style="color: hsl(0, 100%, 40%);">-     f_rslem_suspend(RSL2_PROC);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  timer T := 2.0;</span><br><span>      T.start;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18193">change 18193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18193"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7f73ef8cbdf46e31a46c9e1b7ad0fa2bd41c0a12 </div>
<div style="display:none"> Gerrit-Change-Number: 18193 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>