<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18069">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ms_srs: fix numpy import<br><br>numpy is used in a few places in the class code so we need to jhave it<br>available in a bigger scope, while still only loading when needed.<br><br>Change-Id: Iea66e623e1c980a62d691e20dacb00df99fdd78f<br>---<br>M src/osmo_gsm_tester/obj/ms_srs.py<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/obj/ms_srs.py b/src/osmo_gsm_tester/obj/ms_srs.py</span><br><span>index 5805fef..4790e76 100644</span><br><span>--- a/src/osmo_gsm_tester/obj/ms_srs.py</span><br><span>+++ b/src/osmo_gsm_tester/obj/ms_srs.py</span><br><span>@@ -353,6 +353,8 @@</span><br><span>         metrics = srsUEMetrics(self.metrics_file)</span><br><span>         return metrics.verify(value, operation, metric, criterion)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+numpy = None</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> class srsUEMetrics(log.Origin):</span><br><span> </span><br><span>     VALID_OPERATIONS = ['avg', 'sum']</span><br><span>@@ -365,7 +367,10 @@</span><br><span>         super().__init__(log.C_RUN, 'srsue_metrics')</span><br><span>         self.raw_data = None</span><br><span>         self.metrics_file = metrics_file</span><br><span style="color: hsl(0, 100%, 40%);">-        import numpy</span><br><span style="color: hsl(120, 100%, 40%);">+        global numpy</span><br><span style="color: hsl(120, 100%, 40%);">+        if numpy is None:</span><br><span style="color: hsl(120, 100%, 40%);">+            import numpy as numpy_module</span><br><span style="color: hsl(120, 100%, 40%);">+            numpy = numpy_module</span><br><span>         # read CSV, guessing data type with first row being the legend</span><br><span>         try:</span><br><span>             self.raw_data = numpy.genfromtxt(self.metrics_file, names=True, delimiter=';', dtype=None)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18069">change 18069</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18069"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iea66e623e1c980a62d691e20dacb00df99fdd78f </div>
<div style="display:none"> Gerrit-Change-Number: 18069 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>