<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/18211">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">commands: add features to verify data written to files<br><br>When writing to files we often just write without making sure that the<br>actual file contents actually written. Lets add features to do a<br>read-after-write verification when writing to files.<br><br>Change-Id: I7be842004102f4998af376790c97647c107be3d5<br>---<br>M pySim/commands.py<br>1 file changed, 20 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/18211/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/commands.py b/pySim/commands.py</span><br><span>index 30e995c..e077289 100644</span><br><span>--- a/pySim/commands.py</span><br><span>+++ b/pySim/commands.py</span><br><span>@@ -122,10 +122,18 @@</span><br><span>            pdu = self.cla_byte + 'b0%04x%02x' % (offset, (min(256, length) & 0xff))</span><br><span>                 return self._tp.send_apdu(pdu)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      def update_binary(self, ef, data, offset=0):</span><br><span style="color: hsl(120, 100%, 40%);">+  def update_binary(self, ef, data, offset=0, verify=False):</span><br><span>           self.select_file(ef)</span><br><span>                 pdu = self.cla_byte + 'd6%04x%02x' % (offset, len(data) // 2) + data</span><br><span style="color: hsl(0, 100%, 40%);">-            return self._tp.send_apdu_checksw(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+                res = self._tp.send_apdu_checksw(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+         if verify:</span><br><span style="color: hsl(120, 100%, 40%);">+                    self.verify_binary(ef, data, offset)</span><br><span style="color: hsl(120, 100%, 40%);">+          return res</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  def verify_binary(self, ef, data, offset=0):</span><br><span style="color: hsl(120, 100%, 40%);">+          res = self.read_binary(ef, len(data) // 2, offset)</span><br><span style="color: hsl(120, 100%, 40%);">+            if res[0].lower() != data.lower():</span><br><span style="color: hsl(120, 100%, 40%);">+                    raise ValueError('Binary verification failed (expected %s, got %s)' % (data.lower(), res[0].lower()))</span><br><span> </span><br><span>    def read_record(self, ef, rec_no):</span><br><span>           r = self.select_file(ef)</span><br><span>@@ -133,7 +141,7 @@</span><br><span>               pdu = self.cla_byte + 'b2%02x04%02x' % (rec_no, rec_length)</span><br><span>          return self._tp.send_apdu(pdu)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      def update_record(self, ef, rec_no, data, force_len=False):</span><br><span style="color: hsl(120, 100%, 40%);">+   def update_record(self, ef, rec_no, data, force_len=False, verify=False):</span><br><span>            r = self.select_file(ef)</span><br><span>             if not force_len:</span><br><span>                    rec_length = self.__record_len(r)</span><br><span>@@ -142,7 +150,15 @@</span><br><span>             else:</span><br><span>                        rec_length = len(data) // 2</span><br><span>          pdu = (self.cla_byte + 'dc%02x04%02x' % (rec_no, rec_length)) + data</span><br><span style="color: hsl(0, 100%, 40%);">-            return self._tp.send_apdu_checksw(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+                res = self._tp.send_apdu_checksw(pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+         if verify:</span><br><span style="color: hsl(120, 100%, 40%);">+                    self.verify_record(ef, rec_no, data)</span><br><span style="color: hsl(120, 100%, 40%);">+          return res</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  def verify_record(self, ef, rec_no, data):</span><br><span style="color: hsl(120, 100%, 40%);">+            res = self.read_record(ef, rec_no)</span><br><span style="color: hsl(120, 100%, 40%);">+            if res[0].lower() != data.lower():</span><br><span style="color: hsl(120, 100%, 40%);">+                    raise ValueError('Record verification failed (expected %s, got %s)' % (data.lower(), res[0].lower()))</span><br><span> </span><br><span>    def record_size(self, ef):</span><br><span>           r = self.select_file(ef)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/18211">change 18211</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/18211"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7be842004102f4998af376790c97647c107be3d5 </div>
<div style="display:none"> Gerrit-Change-Number: 18211 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>