<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18189">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test: Properly allocate MSC data struct.<br><br>Without a properly allocated MSC struct, touching counters crashes<br>the test.<br><br>Change-Id: I7498d2891259be9b532845627f14ac75e98e703e<br>---<br>M tests/handover/handover_test.c<br>1 file changed, 1 insertion(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/18189/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index 0d98717..bdc18c3 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -217,19 +217,11 @@</span><br><span> </span><br><span> void create_conn(struct gsm_lchan *lchan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    static struct bsc_msc_data fake_msc_data = {};</span><br><span style="color: hsl(0, 100%, 40%);">-  fake_msc_data.network = bsc_gsmnet;</span><br><span>  static unsigned int next_imsi = 0;</span><br><span>   char imsi[sizeof(lchan->conn->bsub->imsi)];</span><br><span>         struct gsm_network *net = lchan->ts->trx->bts->network;</span><br><span>  struct gsm_subscriber_connection *conn;</span><br><span>      struct mgcp_client *fake_mgcp_client = (void*)talloc_zero(net, int);</span><br><span style="color: hsl(0, 100%, 40%);">-    uint8_t *amr_conf;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      /* HACK: lchan_fsm.c requires some AMR codec rates to be enabled,</span><br><span style="color: hsl(0, 100%, 40%);">-        * lets pretend that all AMR codec rates are allowed */</span><br><span style="color: hsl(0, 100%, 40%);">- amr_conf = (uint8_t*) &fake_msc_data.amr_conf;</span><br><span style="color: hsl(0, 100%, 40%);">-        amr_conf[1] = 0xff;</span><br><span> </span><br><span>    conn = bsc_subscr_con_allocate(net);</span><br><span> </span><br><span>@@ -239,7 +231,7 @@</span><br><span>                                                          net->mgw.tdefs,</span><br><span>                                                           "test",</span><br><span>                                                            "fake endpoint");</span><br><span style="color: hsl(0, 100%, 40%);">-  conn->sccp.msc = &fake_msc_data;</span><br><span style="color: hsl(120, 100%, 40%);">+       conn->sccp.msc = osmo_msc_data_alloc(net, 0);</span><br><span> </span><br><span>         lchan->conn = conn;</span><br><span>       conn->lchan = lchan;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18189">change 18189</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18189"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7498d2891259be9b532845627f14ac75e98e703e </div>
<div style="display:none"> Gerrit-Change-Number: 18189 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>