<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18188">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Only dereference a connection pointer after checking for NULL.<br><br>Addresses CID 210261.<br><br>Change-Id: Ic7e7c92c5b9ff696fa7f4cd0d69451cd22333f71<br>---<br>M src/osmo-bsc/osmo_bsc_bssap.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/18188/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>index f1e43be..b92e39a 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>@@ -1104,7 +1104,7 @@</span><br><span>        struct msgb *gsm48;</span><br><span>  uint8_t *data;</span><br><span>       int rc, dtap_rc;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct rate_ctr *ctrs = conn->sccp.msc->msc_ctrs->ctr;</span><br><span style="color: hsl(120, 100%, 40%);">+       struct rate_ctr *ctrs;</span><br><span> </span><br><span>   LOGP(DMSC, LOGL_DEBUG, "Rx MSC DTAP: %s\n",</span><br><span>                osmo_hexdump(msg->l3h, length));</span><br><span>@@ -1114,6 +1114,7 @@</span><br><span>          return -1;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ ctrs = conn->sccp.msc->msc_ctrs->ctr;</span><br><span>       header = (struct dtap_header *) msg->l3h;</span><br><span>         if (sizeof(*header) >= length) {</span><br><span>          rate_ctr_inc(&ctrs[MSC_CTR_BSSMAP_RX_DTAP_ERROR]);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18188">change 18188</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18188"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic7e7c92c5b9ff696fa7f4cd0d69451cd22333f71 </div>
<div style="display:none"> Gerrit-Change-Number: 18188 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>