<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix nullpointer: in gsm48_rx_gmm_ra_upd_req()<br><br>This caused frequent crashes at 36c3. The "proper" fix is probably elsewhere<br>(lynxis mentions an unfinished patch), but at least this prevented some crashes<br>during active operation.<br><br>Once this is merged, we can (re)enable SGSN_Tests_Iu.TC_geran_attach_iu_rau,<br>which tests exactly for this scenario:  A Subscriber / MM context that is so<br>far attached via GERAN, but now receives a RAU via UTRAN/Iu.<br><br>Closes: OS#4339<br>Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc<br>---<br>M src/sgsn/gprs_gmm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c</span><br><span>index 03ff513..0391229 100644</span><br><span>--- a/src/sgsn/gprs_gmm.c</span><br><span>+++ b/src/sgsn/gprs_gmm.c</span><br><span>@@ -1682,7 +1682,7 @@</span><br><span>         rate_ctr_inc(&mmctx->ctrg->ctr[GMM_CTR_PKTS_SIG_IN]);</span><br><span> </span><br><span>  /* Update the MM context with the new RA-ID */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (mmctx->ran_type == MM_CTX_T_GERAN_Gb) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (mmctx->ran_type == MM_CTX_T_GERAN_Gb && msgb_bcid(msg)) {</span><br><span>             bssgp_parse_cell_id(&mmctx->ra, msgb_bcid(msg));</span><br><span>              /* Update the MM context with the new (i.e. foreign) TLLI */</span><br><span>                 mmctx->gb.tlli = msgb_tlli(msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744">change 16744</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc </div>
<div style="display:none"> Gerrit-Change-Number: 16744 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>