<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18115">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  keith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf: Avoid crash: don't set TBF window size if setup failed<br><br>Should fix assertion triggered due to the tbf not set up properly<br>beforehand.<br><br>Fixes: OS#4524<br>Change-Id: I267b147520ef5a50f40ad4bc19e7b5fb3e708127<br>---<br>M src/tbf.cpp<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 73d7ea9..fb985d4 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -1014,15 +1014,15 @@</span><br><span> </span><br><span>       rc = setup_tbf(tbf, ms, use_trx, ms_class, egprs_ms_class, single_slot);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (tbf->is_egprs_enabled())</span><br><span style="color: hsl(0, 100%, 40%);">-         tbf->set_window_size();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   /* if no resource */</span><br><span>         if (rc < 0) {</span><br><span>             talloc_free(tbf);</span><br><span>            return NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (tbf->is_egprs_enabled())</span><br><span style="color: hsl(120, 100%, 40%);">+               tbf->set_window_size();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(tbf,</span><br><span>                                  &tbf_ul_egprs_ctrg_desc, tbf->m_ctrs->idx);</span><br><span>        tbf->m_ul_gprs_ctrs = rate_ctr_group_alloc(tbf,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/18115">change 18115</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/18115"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I267b147520ef5a50f40ad4bc19e7b5fb3e708127 </div>
<div style="display:none"> Gerrit-Change-Number: 18115 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>