<p>Earwin @ Fairwaves has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18173">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">statsd: fix rendering for groups with idx==0<br><br>while skipping `0` might be visually pleasant for non-repeating groups, e.g.:<br>    bsc.assignment.completed<br><br>it makes metrics parsing very awkward for repeating groups, e.g.:<br>    bts.chreq.total<br>    bts.1.chreq.total<br>    bts.2.chreq.total<br><br>and since nobody's going to look at raw statsd stream anyway,<br>we can live with some extra zeroes<br><br>Change-Id: Id294202fbcebe0b6b155c7f267b2da73af20adf4<br>---<br>M src/stats_statsd.c<br>1 file changed, 6 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/18173/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/stats_statsd.c b/src/stats_statsd.c</span><br><span>index c3f739e..d449667 100644</span><br><span>--- a/src/stats_statsd.c</span><br><span>+++ b/src/stats_statsd.c</span><br><span>@@ -99,24 +99,16 @@</span><br><span>     int old_len = msgb_length(srep->buffer);</span><br><span> </span><br><span>      if (prefix) {</span><br><span style="color: hsl(0, 100%, 40%);">-           if (name1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (index1 != 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                                fmt = "%1$s.%2$s.%6$u.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-                        else</span><br><span style="color: hsl(0, 100%, 40%);">-                            fmt = "%1$s.%2$s.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-             } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (name1)</span><br><span style="color: hsl(120, 100%, 40%);">+                    fmt = "%1$s.%2$s.%6$u.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span>                         fmt = "%1$s.%2$0.0s%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-           }</span><br><span>    } else {</span><br><span>             prefix = "";</span><br><span style="color: hsl(0, 100%, 40%);">-          if (name1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (index1 != 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                                fmt = "%1$s%2$s.%6$u.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-                 else</span><br><span style="color: hsl(0, 100%, 40%);">-                            fmt = "%1$s%2$s.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-              } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (name1)</span><br><span style="color: hsl(120, 100%, 40%);">+                    fmt = "%1$s%2$s.%6$u.%3$s:%4$d|%5$s";</span><br><span style="color: hsl(120, 100%, 40%);">+               else</span><br><span>                         fmt = "%1$s%2$0.0s%3$s:%4$d|%5$s";</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span>    }</span><br><span> </span><br><span>        if (srep->agg_enabled) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18173">change 18173</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18173"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id294202fbcebe0b6b155c7f267b2da73af20adf4 </div>
<div style="display:none"> Gerrit-Change-Number: 18173 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Earwin @ Fairwaves <earwin@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>