<p>tnt has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18114">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">e1_input: Add VTY command to enable PCAP debug output<br><br>The command must be put first, since only lines created after it are<br>affected.<br><br>This limits the usefulness of changing at runtime or of the 'no' command<br>except to set it up properly before a 'write config'.<br><br>Signed-off-by: Sylvain Munaut <tnt@246tNt.com><br>Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454<br>---<br>M src/e1_input_vty.c<br>1 file changed, 42 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/14/18114/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c</span><br><span>index 8d89d04..cdee672 100644</span><br><span>--- a/src/e1_input_vty.c</span><br><span>+++ b/src/e1_input_vty.c</span><br><span>@@ -20,9 +20,12 @@</span><br><span>  */</span><br><span> #include "internal.h"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <fcntl.h></span><br><span> #include <stdlib.h></span><br><span> #include <unistd.h></span><br><span> #include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <sys/stat.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <sys/types.h></span><br><span> #include <sys/un.h></span><br><span> </span><br><span> #include <osmocom/core/linuxlist.h></span><br><span>@@ -232,6 +235,39 @@</span><br><span>       return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static char *pcap_filename = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_e1_pcap, cfg_e1_pcap_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+       "pcap .FILE",</span><br><span style="color: hsl(120, 100%, 40%);">+       "Setup a pcap recording of all E1 traffic\n"</span><br><span style="color: hsl(120, 100%, 40%);">+        "Filename to save the packets to\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     int fd;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     fd = open(argv[0], O_WRONLY | O_CREAT | O_TRUNC, 0660);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (fd < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              vty_out(vty, "Failed to setup E1 pcap recording to %s.%s", argv[1], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+           return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   talloc_free(pcap_filename);</span><br><span style="color: hsl(120, 100%, 40%);">+   pcap_filename = talloc_strdup(NULL, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       e1_set_pcap_fd(fd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_e1_no_pcap, cfg_e1_no_pcap_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+   NO_STR "pcap",</span><br><span style="color: hsl(120, 100%, 40%);">+      "Disable pcap recording of all E1 traffic\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    talloc_free(pcap_filename);</span><br><span style="color: hsl(120, 100%, 40%);">+   pcap_filename = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ e1_set_pcap_fd(-1);</span><br><span style="color: hsl(120, 100%, 40%);">+   return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_e1inp, cfg_e1inp_cmd,</span><br><span>  "e1_input",</span><br><span>        "Configure E1/T1/J1 TDM input\n")</span><br><span>@@ -261,6 +297,9 @@</span><br><span> </span><br><span>        vty_out(vty, "e1_input%s", VTY_NEWLINE);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        if (pcap_filename)</span><br><span style="color: hsl(120, 100%, 40%);">+            vty_out(vty, " pcap %s%s", pcap_filename, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  llist_for_each_entry(line, &e1inp_line_list, list) {</span><br><span>             vty_out(vty, " e1_line %u driver %s%s", line->num,</span><br><span>                      line->driver->name, VTY_NEWLINE);</span><br><span>@@ -436,6 +475,9 @@</span><br><span>        install_element(CONFIG_NODE, &cfg_e1inp_cmd);</span><br><span>    install_node(&e1inp_node, e1inp_config_write);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        install_element(L_E1INP_NODE, &cfg_e1_pcap_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+  install_element(L_E1INP_NODE, &cfg_e1_no_pcap_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    install_element(L_E1INP_NODE, &cfg_e1_line_driver_cmd);</span><br><span>  install_element(L_E1INP_NODE, &cfg_e1_line_port_cmd);</span><br><span>    install_element(L_E1INP_NODE, &cfg_e1_line_socket_cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18114">change 18114</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/18114"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 </div>
<div style="display:none"> Gerrit-Change-Number: 18114 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>