<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance<br><br>This test case would not fail even in case of Timing Advance mismatch.<br><br>Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9<br>Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com><br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index e848ea6..a40819d 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -727,8 +727,11 @@</span><br><span>                 }</span><br><span> </span><br><span>                /* Make sure Timing Advance IE matches out expectations */</span><br><span style="color: hsl(0, 100%, 40%);">-              if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, ta := ta))) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+             if (rr_msg.payload.imm_ass.timing_advance != ta) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    setverdict(fail, "Timing Advance mismatch: ",</span><br><span style="color: hsl(120, 100%, 40%);">+                                  rr_msg.payload.imm_ass.timing_advance,</span><br><span style="color: hsl(120, 100%, 40%);">+                                " vs expected ", ta);</span><br><span style="color: hsl(120, 100%, 40%);">+                    mtc.stop;</span><br><span>            }</span><br><span>    }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080">change 18080</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9 </div>
<div style="display:none"> Gerrit-Change-Number: 18080 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>