<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18079">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU: cosmetic: simplify f_imm_ass_verify_ul_tbf_ass()<br><br>Do not match the whole RR Immediate Assignment, only the Rest Octets.<br><br>Change-Id: If0affebb5944a657d4382fbc6d2c2bdeae444425<br>Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com><br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/18079/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index e848ea6..865c0ee 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -361,10 +361,11 @@</span><br><span> </span><br><span> private function f_imm_ass_verify_ul_tbf_ass(in GsmRrMessage rr_imm_ass, out PacketUlAssign ul_tbf_ass)</span><br><span> runs on RAW_PCU_Test_CT return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+    var IaRestOctets rest_octets := rr_imm_ass.payload.imm_ass.rest_octets;</span><br><span> </span><br><span>  /* Make sure we received an UL TBF Assignment */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (match(rr_imm_ass, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)))) {</span><br><span style="color: hsl(0, 100%, 40%);">-         ul_tbf_ass := rr_imm_ass.payload.imm_ass.rest_octets.hh.pa.uldl.ass.ul;</span><br><span style="color: hsl(120, 100%, 40%);">+       if (match(rest_octets, tr_IaRestOctets_ULAss(?))) {</span><br><span style="color: hsl(120, 100%, 40%);">+           ul_tbf_ass := rest_octets.hh.pa.uldl.ass.ul;</span><br><span>                 log("Rx Uplink TBF assignment: ", ul_tbf_ass);</span><br><span>             setverdict(pass);</span><br><span>    } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18079">change 18079</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18079"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If0affebb5944a657d4382fbc6d2c2bdeae444425 </div>
<div style="display:none"> Gerrit-Change-Number: 18079 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>