<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18034">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurement: make measurements more debugable<br><br>A debug line is printed whenever a measurement is added and it also<br>displays if the added measurement is a sub frame or not, lets display<br>all the other properties too, especially inv_rssi would help a lot as it<br>shows us the rssi values which are reported by the lower layers<br><br>Related: OS#2978<br>Change-Id: I0299b75e99661e8dd22ad6604a897db4533c3b2b<br>---<br>M src/common/measurement.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index c5cbbb0..3ee9ffe 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -341,8 +341,10 @@</span><br><span>      if (!ulm->is_sub)</span><br><span>                 ulm->is_sub = ts45008_83_is_sub(lchan, fn);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      DEBUGPFN(DMEAS, fn, "%s adding measurement (is_sub=%u), num_ul_meas=%d, fn_mod=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">-          gsm_lchan_name(lchan), ulm->is_sub, lchan->meas.num_ul_meas, fn_mod);</span><br><span style="color: hsl(120, 100%, 40%);">+  DEBUGPFN(DMEAS, fn, "%s adding measurement (ber10k=%u, ta_offs=%d, ci=%0.2f, is_sub=%u, rssi=-%u), num_ul_meas=%d, fn_mod=%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             gsm_lchan_name(lchan), ulm->ber10k, ulm->ta_offs_256bits,</span><br><span style="color: hsl(120, 100%, 40%);">+               ulm->c_i, ulm->is_sub, ulm->inv_rssi, lchan->meas.num_ul_meas,</span><br><span style="color: hsl(120, 100%, 40%);">+            fn_mod);</span><br><span> </span><br><span>        memcpy(&lchan->meas.uplink[lchan->meas.num_ul_meas++], ulm,</span><br><span>                sizeof(*ulm));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18034">change 18034</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18034"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0299b75e99661e8dd22ad6604a897db4533c3b2b </div>
<div style="display:none"> Gerrit-Change-Number: 18034 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>