<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18038">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_gsup_req_new(): require from_peer != NULL<br><br>In practice, from_peer is always non-NULL, yet some conditions checked against<br>NULL, looking like a possible NULL deref. Require non-NULL.<br><br>Related: coverity CID#210172<br>Change-Id: I3cb73ec0d31f84d4b613ecb026169c944d240e4c<br>---<br>M src/gsupclient/gsup_req.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/38/18038/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsupclient/gsup_req.c b/src/gsupclient/gsup_req.c</span><br><span>index a8a66d5..2e7caf1 100644</span><br><span>--- a/src/gsupclient/gsup_req.c</span><br><span>+++ b/src/gsupclient/gsup_req.c</span><br><span>@@ -107,6 +107,12 @@</span><br><span>      struct osmo_gsup_req *req;</span><br><span>   int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   if (!from_peer) {</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DLGSUP, LOGL_ERROR, "Rx GSUP from NULL peer is not allowed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+               return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (!msgb_l2(msg) || !msgb_l2len(msg)) {</span><br><span>             LOGP(DLGSUP, LOGL_ERROR, "Rx GSUP from %s: missing or empty L2 data\n",</span><br><span>                 osmo_cni_peer_id_to_str(from_peer));</span><br><span>@@ -121,8 +127,7 @@</span><br><span>      req->msg = msg;</span><br><span>   req->send_response_cb = send_response_cb;</span><br><span>         req->cb_data = cb_data;</span><br><span style="color: hsl(0, 100%, 40%);">-      if (from_peer)</span><br><span style="color: hsl(0, 100%, 40%);">-          req->source_name = *from_peer;</span><br><span style="color: hsl(120, 100%, 40%);">+     req->source_name = *from_peer;</span><br><span>    rc = osmo_gsup_decode(msgb_l2(req->msg), msgb_l2len(req->msg), (struct osmo_gsup_message*)&req->gsup);</span><br><span>  if (rc < 0) {</span><br><span>             LOGP(DLGSUP, LOGL_ERROR, "Rx GSUP from %s: cannot decode (rc=%d)\n", osmo_cni_peer_id_to_str(from_peer), rc);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18038">change 18038</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/18038"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3cb73ec0d31f84d4b613ecb026169c944d240e4c </div>
<div style="display:none"> Gerrit-Change-Number: 18038 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>