<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18041">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr_subscr_nam(): fix condition to fix nam=false notifications<br><br>Firstly, vlr_number[] is an array and we need to check the first char for nul<br>instead of the pointer.<br><br>Also, osmo_ipa_name_set_str() returns zero on success, so the condition is<br>reversed.<br><br>hlr_subscr_nam() was rewritten in I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9<br>ad868e29ba1b838f151cdf2ad9cb4f068a817493 and this likely fixes a bug introduced<br>there.<br><br>Related: coverity CID#210169<br>Change-Id: I3a0e9ed4b865c88aa4a6341a3bf1a96c10d20ed9<br>---<br>M src/hlr.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index 7b803e7..e4d6c23 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -268,9 +268,9 @@</span><br><span>   if (nam_val)</span><br><span>                 return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (subscr->vlr_number && osmo_ipa_name_set_str(&vlr_name, subscr->vlr_number))</span><br><span style="color: hsl(120, 100%, 40%);">+     if (subscr->vlr_number[0] && !osmo_ipa_name_set_str(&vlr_name, subscr->vlr_number))</span><br><span>                osmo_gsup_enc_send_to_ipa_name(g_hlr->gs, &vlr_name, &gsup_del_data);</span><br><span style="color: hsl(0, 100%, 40%);">-        if (subscr->sgsn_number && osmo_ipa_name_set_str(&vlr_name, subscr->sgsn_number))</span><br><span style="color: hsl(120, 100%, 40%);">+   if (subscr->sgsn_number[0] && !osmo_ipa_name_set_str(&vlr_name, subscr->sgsn_number))</span><br><span>              osmo_gsup_enc_send_to_ipa_name(g_hlr->gs, &vlr_name, &gsup_del_data);</span><br><span>     return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/18041">change 18041</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/18041"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3a0e9ed4b865c88aa4a6341a3bf1a96c10d20ed9 </div>
<div style="display:none"> Gerrit-Change-Number: 18041 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>