<p>tnt has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18062">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">om2k: Fix TS channel config payload for non-superchannel case<br><br>* In superchannel mode, those 3 are required.<br>* In normal mode, "Config Type" is optional and the two others are<br>forbidden.<br><br>Signed-off-by: Sylvain Munaut <tnt@246tNt.com><br>Change-Id: If02d02c067ae8af8ce693ddfb8747212f3f4e441<br>---<br>M src/osmo-bsc/abis_om2000.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/18062/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c</span><br><span>index d5eb24a..355389b 100644</span><br><span>--- a/src/osmo-bsc/abis_om2000.c</span><br><span>+++ b/src/osmo-bsc/abis_om2000.c</span><br><span>@@ -1479,10 +1479,14 @@</span><br><span>             msgb_tv_put(msg, OM2K_DEI_LSC_FILT_TIME, 10);   /* units of 100ms */</span><br><span>                 msgb_tv_put(msg, OM2K_DEI_CALL_SUPV_TIME, 8);</span><br><span>                msgb_tv_put(msg, OM2K_DEI_ENCR_ALG, 0x00);</span><br><span style="color: hsl(0, 100%, 40%);">-              /* Not sure what those below mean */</span><br><span style="color: hsl(0, 100%, 40%);">-            msgb_tv_put(msg, 0x9e, 0x00);</span><br><span style="color: hsl(0, 100%, 40%);">-           msgb_tv_put(msg, 0x9f, 0x37);</span><br><span style="color: hsl(0, 100%, 40%);">-           msgb_tv_put(msg, 0xa0, 0x01);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+               /* Those are only use for superchannel */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (ts->trx->bts->rbs2000.use_superchannel) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        msgb_tv_put(msg, OM2K_DEI_CONFIG_TYPE,  0x00);  /* 1-bit, lsb */</span><br><span style="color: hsl(120, 100%, 40%);">+                      msgb_tv_put(msg, OM2K_DEI_JITTER_SIZE,  0x37);</span><br><span style="color: hsl(120, 100%, 40%);">+                        msgb_tv_put(msg, OM2K_DEI_PACKING_ALGO, 0x01);</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          break;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18062">change 18062</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18062"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If02d02c067ae8af8ce693ddfb8747212f3f4e441 </div>
<div style="display:none"> Gerrit-Change-Number: 18062 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>