<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18011">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library: get rid of Si1RestOctets and Si3RestOctets<br><br>Both are basically sub-types of GSM_RR_Types.RestOctets with length<br>constraints. We don't really need to have them as separate symbols,<br>especially since we have SI3RestOctets and SI4RestOctets now, so<br>let's apply these constraints within the corresponding records.<br><br>Change-Id: I2b126348ae5c5425fea4267ab2b77ea0192795ac<br>Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com><br>---<br>M library/GSM_SystemInformation.ttcn<br>1 file changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_SystemInformation.ttcn b/library/GSM_SystemInformation.ttcn</span><br><span>index f1918c9..a4688cd 100644</span><br><span>--- a/library/GSM_SystemInformation.ttcn</span><br><span>+++ b/library/GSM_SystemInformation.ttcn</span><br><span>@@ -115,16 +115,14 @@</span><br><span>            AccessControlClass acc</span><br><span>       } with { variant (acc) "FIELDLENGTH(16)" };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       /* 44.018 10.5.2.32 */</span><br><span style="color: hsl(0, 100%, 40%);">-  type RestOctets Si1RestOctets with { variant "FIELDLENGTH(1)" };</span><br><span style="color: hsl(0, 100%, 40%);">-      type RestOctets Si3RestOctets with { variant "FIELDLENGTH(4)" };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   /* 44.018 9.1.31 */</span><br><span>  type record SystemInformationType1 {</span><br><span>                 CellChannelDescription  cell_chan_desc,</span><br><span>              RachControlParameters   rach_control,</span><br><span style="color: hsl(0, 100%, 40%);">-           Si1RestOctets           rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">-     } with { variant "" };</span><br><span style="color: hsl(120, 100%, 40%);">+              RestOctets              rest_octets</span><br><span style="color: hsl(120, 100%, 40%);">+   } with {</span><br><span style="color: hsl(120, 100%, 40%);">+              variant (rest_octets) "FIELDLENGTH(1)"</span><br><span style="color: hsl(120, 100%, 40%);">+      };</span><br><span> </span><br><span>       /* 44.018 9.1.32 */</span><br><span>  type record SystemInformationType2 {</span><br><span>@@ -154,8 +152,10 @@</span><br><span>          CellOptions                     cell_options,</span><br><span>                CellSelectionParameters         cell_sel_par,</span><br><span>                RachControlParameters           rach_control,</span><br><span style="color: hsl(0, 100%, 40%);">-           Si3RestOctets                   rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">-     } with { variant "" };</span><br><span style="color: hsl(120, 100%, 40%);">+              RestOctets                      rest_octets</span><br><span style="color: hsl(120, 100%, 40%);">+   } with {</span><br><span style="color: hsl(120, 100%, 40%);">+              variant (rest_octets) "FIELDLENGTH(4)"</span><br><span style="color: hsl(120, 100%, 40%);">+      };</span><br><span> </span><br><span>       template SystemInformationType3 t_SI3 := {</span><br><span>           cell_id := ?,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18011">change 18011</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18011"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b126348ae5c5425fea4267ab2b77ea0192795ac </div>
<div style="display:none"> Gerrit-Change-Number: 18011 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>