<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18025">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library: relax length constraints applied to SI Rest Octets<br><br>As it turned out, the length constraints introduced in [1] were<br>too strict. In particular, the use of FIELDLENGTH attribute made<br>it impossible to assign an octetstring of a smaller size and then<br>pad the remaining octets with '2B'O. TITAN would just use '00'O<br>instead, ignoring all my attempts to talk some sense into it.<br><br>[1] I183d3ba9000e3ced8ecce74a4390b80075ddf25d<br><br>Change-Id: Ie1b6d4100c064b6ae08ed55cd797b9416c6faf14<br>Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com><br>---<br>M library/GSM_SystemInformation.ttcn<br>1 file changed, 11 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/18025/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_SystemInformation.ttcn b/library/GSM_SystemInformation.ttcn</span><br><span>index 07ca8e6..de1fcf7 100644</span><br><span>--- a/library/GSM_SystemInformation.ttcn</span><br><span>+++ b/library/GSM_SystemInformation.ttcn</span><br><span>@@ -119,10 +119,8 @@</span><br><span> type record SystemInformationType1 {</span><br><span> CellChannelDescription cell_chan_desc,</span><br><span> RachControlParameters rach_control,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- variant (rest_octets) "FIELDLENGTH(1)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..1)</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> /* 44.018 9.1.32 */</span><br><span> type record SystemInformationType2 {</span><br><span>@@ -135,18 +133,14 @@</span><br><span> type record SystemInformationType2bis {</span><br><span> NeighbourCellDescription extd_bcch_freq_list,</span><br><span> RachControlParameters rach_control,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- variant (rest_octets) "FIELDLENGTH(1)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..1)</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> /* 44.018 9.1.34 */</span><br><span> type record SystemInformationType2ter {</span><br><span> NeighbourCellDescription2 extd_bcch_freq_list,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- variant (rest_octets) "FIELDLENGTH(4)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..4)</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> /* 44.018 9.1.35 */</span><br><span> type record SystemInformationType3 {</span><br><span>@@ -156,10 +150,8 @@</span><br><span> CellOptions cell_options,</span><br><span> CellSelectionParameters cell_sel_par,</span><br><span> RachControlParameters rach_control,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- variant (rest_octets) "FIELDLENGTH(4)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..4)</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> template SystemInformationType3 t_SI3 := {</span><br><span> cell_id := ?,</span><br><span>@@ -179,7 +171,7 @@</span><br><span> RachControlParameters rach_control,</span><br><span> ChannelDescriptionTV cbch_chan_desc optional,</span><br><span> MobileAllocationT cbch_mobile_alloc optional,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets /* 0 .. 10 octets (see 10.5.2.35) */</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..10) /* see 10.5.2.35 */</span><br><span> } with { variant "TAG(cbch_chan_desc, iei = '64'O; cbch_mobile_alloc, iei = '72'O)" };</span><br><span> </span><br><span> /* 44.018 9.1.37 */</span><br><span>@@ -203,10 +195,8 @@</span><br><span> LocationAreaIdentification lai,</span><br><span> CellOptionsSacch cell_options,</span><br><span> BIT8 ncc_permitted,</span><br><span style="color: hsl(0, 100%, 40%);">- RestOctets rest_octets</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- variant (rest_octets) "FIELDLENGTH(7)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ RestOctets rest_octets length(0..7)</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> type union SystemInformationUnion {</span><br><span> SystemInformationType1 si1,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18025">change 18025</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18025"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie1b6d4100c064b6ae08ed55cd797b9416c6faf14 </div>
<div style="display:none"> Gerrit-Change-Number: 18025 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>