<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18000">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">HACK: Disable the use of thread-local storage<br><br>This will disable the thread-safe use of many libosmo* featues,<br>but it seems even in 2020 there are still systems out there<br>wthat don't support thread-local-storage.<br><br>Related: OS#4456<br>Related: OS#4062<br>Change-Id: I9baa7047fc4ff1a595ee318dcdb1247f1460da1b<br>---<br>M include/osmocom/core/talloc.h<br>M include/osmocom/gsm/cbsp.h<br>M src/context.c<br>M src/fsm.c<br>M src/gb/gprs_ns.c<br>M src/gsm/abis_nm.c<br>M src/gsm/apn.c<br>M src/gsm/cbsp.c<br>M src/gsm/gsm0808_utils.c<br>M src/gsm/gsm23003.c<br>M src/gsm/gsm48.c<br>M src/gsm/gsm_utils.c<br>M src/gsm/rsl.c<br>M src/msgb.c<br>M src/select.c<br>M src/sim/core.c<br>M src/socket.c<br>M src/utils.c<br>18 files changed, 39 insertions(+), 39 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/18000/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/talloc.h b/include/osmocom/core/talloc.h</span><br><span>index c68a56c..07148df 100644</span><br><span>--- a/include/osmocom/core/talloc.h</span><br><span>+++ b/include/osmocom/core/talloc.h</span><br><span>@@ -19,7 +19,7 @@</span><br><span> void *select;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-extern __thread struct osmo_talloc_contexts *osmo_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct osmo_talloc_contexts *osmo_ctx;</span><br><span> </span><br><span> /* short-hand #defines for the osmo talloc contexts (OTC) that can be used to pass</span><br><span> * to the various _c functions like msgb_alloc_c() */</span><br><span>diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h</span><br><span>index 90516cb..6f7dbad 100644</span><br><span>--- a/include/osmocom/gsm/cbsp.h</span><br><span>+++ b/include/osmocom/gsm/cbsp.h</span><br><span>@@ -283,7 +283,7 @@</span><br><span> } u;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-extern const __thread char *osmo_cbsp_errstr;</span><br><span style="color: hsl(120, 100%, 40%);">+extern const char *osmo_cbsp_errstr;</span><br><span> </span><br><span> struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name);</span><br><span> struct msgb *osmo_cbsp_encode(void *ctx, const struct osmo_cbsp_decoded *in);</span><br><span>diff --git a/src/context.c b/src/context.c</span><br><span>index bad012b..bf13557 100644</span><br><span>--- a/src/context.c</span><br><span>+++ b/src/context.c</span><br><span>@@ -26,7 +26,7 @@</span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/core/utils.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-__thread struct osmo_talloc_contexts *osmo_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_talloc_contexts *osmo_ctx;</span><br><span> </span><br><span> int osmo_ctx_init(const char *id)</span><br><span> {</span><br><span>diff --git a/src/fsm.c b/src/fsm.c</span><br><span>index 1e8909e..60927f2 100644</span><br><span>--- a/src/fsm.c</span><br><span>+++ b/src/fsm.c</span><br><span>@@ -95,7 +95,7 @@</span><br><span> static bool fsm_term_safely_enabled = false;</span><br><span> </span><br><span> /*! Internal state for FSM instance termination cascades. */</span><br><span style="color: hsl(0, 100%, 40%);">-static __thread struct {</span><br><span style="color: hsl(120, 100%, 40%);">+static struct {</span><br><span> /*! The first FSM instance that invoked osmo_fsm_inst_term() in the current cascade. */</span><br><span> struct osmo_fsm_inst *root_fi;</span><br><span> /*! 2 if a secondary FSM terminates, 3 if a secondary FSM causes a tertiary FSM to terminate, and so on. */</span><br><span>@@ -583,7 +583,7 @@</span><br><span> */</span><br><span> const char *osmo_fsm_event_name(struct osmo_fsm *fsm, uint32_t event)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> if (!fsm->event_names) {</span><br><span> snprintf(buf, sizeof(buf), "%"PRIu32, event);</span><br><span> return buf;</span><br><span>@@ -613,7 +613,7 @@</span><br><span> */</span><br><span> const char *osmo_fsm_state_name(struct osmo_fsm *fsm, uint32_t state)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> if (state >= fsm->num_states) {</span><br><span> snprintf(buf, sizeof(buf), "unknown %"PRIu32, state);</span><br><span> return buf;</span><br><span>diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c</span><br><span>index 4e584ad..ede5152 100644</span><br><span>--- a/src/gb/gprs_ns.c</span><br><span>+++ b/src/gb/gprs_ns.c</span><br><span>@@ -1553,7 +1553,7 @@</span><br><span> </span><br><span> const char *gprs_ns_ll_str(const struct gprs_nsvc *nsvc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[80];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[80];</span><br><span> return gprs_ns_ll_str_buf(buf, sizeof(buf), nsvc);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/abis_nm.c b/src/gsm/abis_nm.c</span><br><span>index 3fb8f0f..28bddd7 100644</span><br><span>--- a/src/gsm/abis_nm.c</span><br><span>+++ b/src/gsm/abis_nm.c</span><br><span>@@ -939,7 +939,7 @@</span><br><span> </span><br><span> const char *abis_nm_dump_foh(const struct abis_om_fom_hdr *foh)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char foh_buf[128];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char foh_buf[128];</span><br><span> return abis_nm_dump_foh_buf(foh_buf, sizeof(foh_buf), foh);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/apn.c b/src/gsm/apn.c</span><br><span>index a7074ea..c5169ad 100644</span><br><span>--- a/src/gsm/apn.c</span><br><span>+++ b/src/gsm/apn.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> #define APN_OI_GPRS_FMT "mnc%03u.mcc%03u.gprs"</span><br><span> #define APN_GPRS_FMT "%s.mnc%03u.mcc%03u.gprs"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static __thread char apn_strbuf[APN_MAXLEN+1];</span><br><span style="color: hsl(120, 100%, 40%);">+static char apn_strbuf[APN_MAXLEN+1];</span><br><span> </span><br><span> char *osmo_apn_qualify_buf(char *buf, size_t buf_len, unsigned int mcc, unsigned int mnc, const char *ni)</span><br><span> {</span><br><span>diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c</span><br><span>index ccc2df5..eb1fbaa 100644</span><br><span>--- a/src/gsm/cbsp.c</span><br><span>+++ b/src/gsm/cbsp.c</span><br><span>@@ -33,7 +33,7 @@</span><br><span> #include <osmocom/gsm/cbsp.h></span><br><span> #include <osmocom/gsm/gsm0808_utils.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const __thread char *osmo_cbsp_errstr;</span><br><span style="color: hsl(120, 100%, 40%);">+const char *osmo_cbsp_errstr;</span><br><span> </span><br><span> struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name)</span><br><span> {</span><br><span>diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c</span><br><span>index 7416d8f..cce7852 100644</span><br><span>--- a/src/gsm/gsm0808_utils.c</span><br><span>+++ b/src/gsm/gsm0808_utils.c</span><br><span>@@ -622,7 +622,7 @@</span><br><span> return ret;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static __thread char dbuf[256];</span><br><span style="color: hsl(120, 100%, 40%);">+static char dbuf[256];</span><br><span> </span><br><span> /*! Dump LCLS parameters (GCR excluded) into string for printing.</span><br><span> * \param[out] buf caller-allocated output string buffer</span><br><span>@@ -1887,7 +1887,7 @@</span><br><span> */</span><br><span> const char *gsm0808_cell_id_name(const struct gsm0808_cell_id *cid)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[64];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[64];</span><br><span> return gsm0808_cell_id_name_buf(buf, sizeof(buf), cid);</span><br><span> }</span><br><span> </span><br><span>@@ -1897,7 +1897,7 @@</span><br><span> */</span><br><span> const char *gsm0808_cell_id_name2(const struct gsm0808_cell_id *cid)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[64];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[64];</span><br><span> return gsm0808_cell_id_name_buf(buf, sizeof(buf), cid);</span><br><span> }</span><br><span> </span><br><span>@@ -1954,7 +1954,7 @@</span><br><span> * See also gsm0808_cell_id_list_name_buf(). */</span><br><span> const char *gsm0808_cell_id_list_name(const struct gsm0808_cell_id_list2 *cil)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[1024];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[1024];</span><br><span> gsm0808_cell_id_list_name_buf(buf, sizeof(buf), cil);</span><br><span> return buf;</span><br><span> }</span><br><span>@@ -1981,7 +1981,7 @@</span><br><span> </span><br><span> const char *gsm0808_channel_type_name(const struct gsm0808_channel_type *ct)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[128];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[128];</span><br><span> return gsm0808_channel_type_name_buf(buf, sizeof(buf), ct);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c</span><br><span>index e20afcb..e5180b8 100644</span><br><span>--- a/src/gsm/gsm23003.c</span><br><span>+++ b/src/gsm/gsm23003.c</span><br><span>@@ -107,7 +107,7 @@</span><br><span> */</span><br><span> const char *osmo_mcc_name(uint16_t mcc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[8];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[8];</span><br><span> return osmo_mcc_name_buf(buf, sizeof(buf), mcc);</span><br><span> }</span><br><span> </span><br><span>@@ -158,7 +158,7 @@</span><br><span> */</span><br><span> const char *osmo_mnc_name(uint16_t mnc, bool mnc_3_digits)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[8];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[8];</span><br><span> return osmo_mnc_name_buf(buf, sizeof(buf), mnc, mnc_3_digits);</span><br><span> }</span><br><span> </span><br><span>@@ -182,7 +182,7 @@</span><br><span> */</span><br><span> const char *osmo_plmn_name(const struct osmo_plmn_id *plmn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[16];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[16];</span><br><span> return osmo_plmn_name_buf(buf, sizeof(buf), plmn);</span><br><span> }</span><br><span> </span><br><span>@@ -193,7 +193,7 @@</span><br><span> */</span><br><span> const char *osmo_plmn_name2(const struct osmo_plmn_id *plmn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[16];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[16];</span><br><span> return osmo_plmn_name_buf(buf, sizeof(buf), plmn);</span><br><span> }</span><br><span> </span><br><span>@@ -230,7 +230,7 @@</span><br><span> */</span><br><span> const char *osmo_lai_name(const struct osmo_location_area_id *lai)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> return osmo_lai_name_buf(buf, sizeof(buf), lai);</span><br><span> }</span><br><span> </span><br><span>@@ -265,7 +265,7 @@</span><br><span> */</span><br><span> const char *osmo_cgi_name(const struct osmo_cell_global_id *cgi)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> return osmo_cgi_name_buf(buf, sizeof(buf), cgi);</span><br><span> }</span><br><span> </span><br><span>@@ -276,7 +276,7 @@</span><br><span> */</span><br><span> const char *osmo_cgi_name2(const struct osmo_cell_global_id *cgi)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> return osmo_cgi_name_buf(buf, sizeof(buf), cgi);</span><br><span> }</span><br><span> </span><br><span>@@ -320,7 +320,7 @@</span><br><span> */</span><br><span> const char *osmo_gummei_name(const struct osmo_gummei *gummei)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> return osmo_gummei_name_buf(buf, sizeof(buf), gummei);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c</span><br><span>index 17b0829..95f0949 100644</span><br><span>--- a/src/gsm/gsm48.c</span><br><span>+++ b/src/gsm/gsm48.c</span><br><span>@@ -203,7 +203,7 @@</span><br><span> */</span><br><span> const char *osmo_rai_name(const struct gprs_ra_id *rai)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[32];</span><br><span> return osmo_rai_name_buf(buf, sizeof(buf), rai);</span><br><span> }</span><br><span> </span><br><span>@@ -502,7 +502,7 @@</span><br><span> */</span><br><span> const char *osmo_mi_name(const uint8_t *mi, uint8_t mi_len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char mi_name[10 + GSM48_MI_SIZE + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char mi_name[10 + GSM48_MI_SIZE + 1];</span><br><span> return osmo_mi_name_buf(mi_name, sizeof(mi_name), mi, mi_len);</span><br><span> }</span><br><span> </span><br><span>@@ -1149,7 +1149,7 @@</span><br><span> */</span><br><span> const char *gsm48_pdisc_msgtype_name(uint8_t pdisc, uint8_t msg_type)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char namebuf[64];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char namebuf[64];</span><br><span> return gsm48_pdisc_msgtype_name_buf(namebuf, sizeof(namebuf), pdisc, msg_type);</span><br><span> }</span><br><span> </span><br><span>@@ -1302,7 +1302,7 @@</span><br><span> */</span><br><span> const char *osmo_gsm48_classmark_a5_name(const struct osmo_gsm48_classmark *cm)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[128];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[128];</span><br><span> return osmo_gsm48_classmark_a5_name_buf(buf, sizeof(buf), cm);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c</span><br><span>index ae77a9d..33a3f8d 100644</span><br><span>--- a/src/gsm/gsm_utils.c</span><br><span>+++ b/src/gsm/gsm_utils.c</span><br><span>@@ -898,7 +898,7 @@</span><br><span> </span><br><span> char *osmo_dump_gsmtime(const struct gsm_time *tm)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[64];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[64];</span><br><span> return osmo_dump_gsmtime_buf(buf, sizeof(buf), tm);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c</span><br><span>index 5534aa2..bba91aa 100644</span><br><span>--- a/src/gsm/rsl.c</span><br><span>+++ b/src/gsm/rsl.c</span><br><span>@@ -264,7 +264,7 @@</span><br><span> */</span><br><span> const char *rsl_chan_nr_str(uint8_t chan_nr)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char str[20];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char str[20];</span><br><span> return rsl_chan_nr_str_buf(str, sizeof(str), chan_nr);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/msgb.c b/src/msgb.c</span><br><span>index 4edbdf3..fc5a9eb 100644</span><br><span>--- a/src/msgb.c</span><br><span>+++ b/src/msgb.c</span><br><span>@@ -511,7 +511,7 @@</span><br><span> */</span><br><span> const char *msgb_hexdump(const struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char buf[4100];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char buf[4100];</span><br><span> return msgb_hexdump_buf(buf, sizeof(buf), msg);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/select.c b/src/select.c</span><br><span>index 8e31205..5971ac5 100644</span><br><span>--- a/src/select.c</span><br><span>+++ b/src/select.c</span><br><span>@@ -52,9 +52,9 @@</span><br><span> </span><br><span> /* keep a set of file descriptors per-thread, so that each thread can have its own</span><br><span> * distinct set of file descriptors to interact with */</span><br><span style="color: hsl(0, 100%, 40%);">-static __thread int maxfd = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-static __thread struct llist_head osmo_fds; /* TLS cannot use LLIST_HEAD() */</span><br><span style="color: hsl(0, 100%, 40%);">-static __thread int unregistered_count;</span><br><span style="color: hsl(120, 100%, 40%);">+static int maxfd = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+static struct llist_head osmo_fds; /* TLS cannot use LLIST_HEAD() */</span><br><span style="color: hsl(120, 100%, 40%);">+static int unregistered_count;</span><br><span> </span><br><span> /*! Set up an osmo-fd. Will not register it.</span><br><span> * \param[inout] ofd Osmo FD to be set-up</span><br><span>diff --git a/src/sim/core.c b/src/sim/core.c</span><br><span>index d11c2d8..f6f022a 100644</span><br><span>--- a/src/sim/core.c</span><br><span>+++ b/src/sim/core.c</span><br><span>@@ -404,7 +404,7 @@</span><br><span> </span><br><span> char *osim_print_sw(const struct osim_chan_hdl *ch, uint16_t sw_in)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char sw_print_buf[256];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char sw_print_buf[256];</span><br><span> return osim_print_sw_buf(sw_print_buf, sizeof(sw_print_buf), ch, sw_in);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/socket.c b/src/socket.c</span><br><span>index 503ceaf..d153c30 100644</span><br><span>--- a/src/socket.c</span><br><span>+++ b/src/socket.c</span><br><span>@@ -1109,7 +1109,7 @@</span><br><span> */</span><br><span> const char *osmo_sock_get_name2(int fd)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread char str[OSMO_SOCK_NAME_MAXLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+ static char str[OSMO_SOCK_NAME_MAXLEN];</span><br><span> osmo_sock_get_name_buf(str, sizeof(str), fd);</span><br><span> return str;</span><br><span> }</span><br><span>diff --git a/src/utils.c b/src/utils.c</span><br><span>index 038288c..565324e 100644</span><br><span>--- a/src/utils.c</span><br><span>+++ b/src/utils.c</span><br><span>@@ -41,9 +41,9 @@</span><br><span> *</span><br><span> * \file utils.c */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static __thread char namebuf[255];</span><br><span style="color: hsl(120, 100%, 40%);">+static char namebuf[255];</span><br><span> /* shared by osmo_str_tolower() and osmo_str_toupper() */</span><br><span style="color: hsl(0, 100%, 40%);">-static __thread char capsbuf[128];</span><br><span style="color: hsl(120, 100%, 40%);">+static char capsbuf[128];</span><br><span> </span><br><span> /*! get human-readable string for given value</span><br><span> * \param[in] vs Array of value_string tuples</span><br><span>@@ -221,7 +221,7 @@</span><br><span> return nibblepos >> 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static __thread char hexd_buff[4096];</span><br><span style="color: hsl(120, 100%, 40%);">+static char hexd_buff[4096];</span><br><span> static const char hex_chars[] = "0123456789abcdef";</span><br><span> </span><br><span> /*! Convert binary sequence to hexadecimal ASCII string.</span><br><span>@@ -494,7 +494,7 @@</span><br><span> * sizeof(uint64_t), only the least significant bytes of value are encoded. */</span><br><span> uint8_t *osmo_encode_big_endian(uint64_t value, size_t data_len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- static __thread uint8_t buf[sizeof(uint64_t)];</span><br><span style="color: hsl(120, 100%, 40%);">+ static uint8_t buf[sizeof(uint64_t)];</span><br><span> OSMO_ASSERT(data_len <= ARRAY_SIZE(buf));</span><br><span> osmo_store64be_ext(value, buf, data_len);</span><br><span> return buf;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18000">change 18000</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18000"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9baa7047fc4ff1a595ee318dcdb1247f1460da1b </div>
<div style="display:none"> Gerrit-Change-Number: 18000 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>