<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/17972">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/input/ipaccess.c: set TCP_NODELAY<br><br>Set TCP_NODELAY for all RSL/OML sockets.<br><br>Related: SYS#4906<br>Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58<br>---<br>M src/input/ipaccess.c<br>1 file changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/72/17972/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index e1936af..4d21416 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -271,6 +271,7 @@</span><br><span>                     struct e1inp_ts *ts;</span><br><span>                         struct osmo_fd *newbfd;</span><br><span>                      struct e1inp_line *new_line;</span><br><span style="color: hsl(120, 100%, 40%);">+                  int on = 1;</span><br><span> </span><br><span>                      sign_link =</span><br><span>                          line->ops->sign_link_up(&unit_data, line,</span><br><span>@@ -309,6 +310,13 @@</span><br><span>                                "could not register FD\n");</span><br><span>                           goto err;</span><br><span>                    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* set TCP_NODELAY (FIXME: just call update_fd_settings() here instead?) */</span><br><span style="color: hsl(120, 100%, 40%);">+                   ret = setsockopt(newbfd->fd, IPPROTO_TCP, TCP_NODELAY, &on, sizeof(on));</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (ret < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                               LOGP(DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                   /* now we can release the dummy RSL line. */</span><br><span>                         e1inp_line_put(line);</span><br><span> </span><br><span>@@ -587,6 +595,11 @@</span><br><span> #endif</span><br><span> #endif</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   val = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+      ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val));</span><br><span style="color: hsl(120, 100%, 40%);">+        if (ret < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno));</span><br><span> }</span><br><span> </span><br><span> /* callback of the OML listening filedescriptor */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/17972">change 17972</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/17972"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58 </div>
<div style="display:none"> Gerrit-Change-Number: 17972 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>